Skip to content

implement function arguments to Dataset.format that triggers removal of NA values in the returned DFs #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ymahlich opened this issue Mar 26, 2025 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request package
Milestone

Comments

@ymahlich
Copy link
Collaborator

If Dataset.experiments contains drug response metrics for cancer samples that have no recorded response values (e.g. auc == NA) those will be returned and included in the formatted Dataframe that is returned by Dataset.format().
We want to add an optional flag (remove_na==True) that will be default remove rows in the returned DF which contain NAs, and returns the complete set (including rows containing NAs) if manually set to False.

This will resolve #322

@ymahlich ymahlich self-assigned this Mar 26, 2025
@ymahlich ymahlich added the enhancement New feature or request label Mar 26, 2025
@sgosline
Copy link
Member

I like the idea of adding a flag, this will remove NA values.

@jjacobson95 jjacobson95 added the bug Something isn't working label May 8, 2025
@jjacobson95 jjacobson95 added this to the v2.2 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request package
Projects
Status: No status
Development

No branches or pull requests

3 participants