Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More issues with parsing players #71

Closed
DavidMente opened this issue Dec 18, 2020 · 2 comments
Closed

More issues with parsing players #71

DavidMente opened this issue Dec 18, 2020 · 2 comments

Comments

@DavidMente
Copy link
Contributor

Similarly to #67 , we have some more failures due to players that cannot be found. I have attached a replay with the issue. This time it's a Netease replay
moju_vs_fly.zip
@PBug90
Copy link
Owner

PBug90 commented Dec 18, 2020

Netease appears to use exactly two CommandDataBlocks for metadata. They use an unknown playerId that does not exist as a valid SlotRecord or PlayerRecord. The first CommandDataBlock appears at 66ms of simulation time. The second seems to appear close to or at the end of the replay.

Since its just 2 blocks and they do not refer to playing players, skipping them is an easy to implement option.

@PBug90
Copy link
Owner

PBug90 commented Dec 18, 2020

Implemented with #72 and published as 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PBug90 @DavidMente