fix: ignore and log encountered CommandDataBlocks for unknown players…

… (nwg) (#72)
PBug90 · Dec 18, 2020 · 7a09b79 · 7a09b79
1 parent cd4994d
commit 7a09b79
Show file tree

Hide file tree

Showing 6 changed files with 2,382 additions and 0 deletions.
diff --git a/src/W3GReplay.ts b/src/W3GReplay.ts
@@ -86,6 +86,7 @@ export default class W3GReplay extends EventEmitter {
   buffer: Buffer;
   msElapsed = 0;
   slotToPlayerId = new Map<number, number>();
+  knownPlayerIds: Set<string>;
 
   constructor() {
     super();
@@ -172,6 +173,8 @@ export default class W3GReplay extends EventEmitter {
         );
       }
     });
+
+    this.knownPlayerIds = new Set(Object.keys(this.players));
   }
 
   processGameDataBlock(block: GameDataBlock): void {
@@ -220,6 +223,12 @@ export default class W3GReplay extends EventEmitter {
   }
 
   processCommandDataBlock(block: CommandBlock): void {
+    if (this.knownPlayerIds.has(String(block.playerId)) === false) {
+      console.log(
+        `detected unknown playerId in CommandBlock: ${block.playerId} - time elapsed: ${this.totalTimeTracker}`
+      );
+      return;
+    }
     const currentPlayer = this.players[block.playerId];
     currentPlayer.currentTimePlayed = this.totalTimeTracker;
     currentPlayer._lastActionWasDeselect = false;

diff --git a/test/replays/132/1582070968.nwg b/test/replays/132/1582070968.nwg
diff --git a/test/replays/132/1582161008.nwg b/test/replays/132/1582161008.nwg