Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails should not contain passwords in plain text #1019

Closed
cdbessig opened this issue Jun 3, 2020 · 3 comments
Closed

Emails should not contain passwords in plain text #1019

cdbessig opened this issue Jun 3, 2020 · 3 comments
Labels

Comments

@cdbessig
Copy link

cdbessig commented Jun 3, 2020

Emails, for one example, app\locale\en_US\template\email\account_new.html contain the user's password in plain text. This should be corrected throughout all locals to not send users passwords.

This is now considered best practice. This has always annoyed me that magento 1.9.4 never took care of this.

Now when I moved to openmage this was overwritten and I got the default functionality back. Since openmage is meant to be Long term support AND feature enhancement of M1, I would consider this as a valid feature request, or even a security issue (possible leak).

What I propose is in each locale change this line:

<strong>Password</strong>: {{htmlescape var=$customer.password}}

To something like this:

<strong>Password</strong>: -- What you entered when you signed up --
@colinmollenhour
Copy link
Member

Thanks for opening this issue, Brian. We discussed this at length at #307 and I think came to a conclusion on what to do but it hasn't been executed on yet. If you can submit a PR that would be awesome!

@kkrieger85
Copy link
Contributor

Shame on me. I assigned #307 and forgot about it.

PR coming today

@sreichel
Copy link
Contributor

Fixed in #1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants