Version v0.9.9.4c as is live on LBI

Author: OliSharpe

WorkBoxFramework/Classes/WBExtensions.cs

@@ -2252,13 +2252,21 @@ public static SPFolder WBxGetOrCreateSubFolder(this SPFolder parent, String chil
 
             if (found == null)
             {
+//                WBLogging.Generic.Unexpected("About to create a child folder with name : " + childName);
+
                 found = parent.SubFolders.Add(childName);
 
+//                WBLogging.Generic.Unexpected("Added child folder with name : " + childName);
+
                 found.Item.SystemUpdate();
                 found.Update();
 
+//                WBLogging.Generic.Unexpected("Done initial update of child folder with name : " + childName);
+
                 found.Item[SPBuiltInFieldId.ContentTypeId] = contentTypeId;
                 found.Item.SystemUpdate();
+
+//                WBLogging.Generic.Unexpected("Updated content type of child folder with name: " + childName);
             }
 
             return found;

WorkBoxFramework/Classes/WBItem.cs

@@ -343,6 +343,9 @@ public void CopyColumns(WBItem itemToCopy)
 
         public bool MaybeCopyColumns(WBItem itemToCopy, IEnumerable<WBColumn> columnsToCopy)
         {
+            // Let's pick up the item again before copying across the metadata:
+            this.Reload();
+
             bool allCorrect = false;
             foreach (WBColumn column in columnsToCopy)
             {

WorkBoxFramework/Classes/WBRecordsLibraries.cs

@@ -238,6 +238,42 @@ public WBRecord DeclareNewRecord(WBTaskFeedback feedback, String callingUserLogi
             protectedLibraryRootFolder.WBxGetOrCreateFolderPath(fullClassPath, classFolderType.Id);
             SPFolder actualDestinationFolder = protectedLibraryRootFolder.WBxGetOrCreateFolderPath(fullFilingPath, filePartFolderType.Id);
 
+            /*
+            // This next bit is all because we've been having problems when new folders had to be created:
+            if (actualDestinationFolder == null)
+            {
+                WBLogging.RecordsTypes.HighLevel("We have to create part of the folder path: " + fullFilingPath); 
+                actualDestinationFolder = protectedLibraryRootFolder.WBxGetOrCreateFolderPath(fullFilingPath, filePartFolderType.Id);
+
+                WBLogging.RecordsTypes.HighLevel("Now we're going to add a dummy first file:");
+
+                MemoryStream memoryStream = new MemoryStream(Encoding.UTF8.GetBytes("Please ignore this file."));
+                SPFile dummyFile = actualDestinationFolder.Files.Add("FirstFile.txt", memoryStream);
+
+                WBLogging.RecordsTypes.HighLevel("Now we're going to try to update the file");
+                try
+                {
+                    dummyFile.Item.Update();
+                }
+                catch (Exception e)
+                {
+                    WBLogging.RecordsTypes.Unexpected("And exception did occur while updating the dummy item", e);
+                }
+
+                memoryStream.Dispose();
+
+                WBLogging.RecordsTypes.HighLevel("Now re-opening the whole ProtectedMasterLibrary object");
+
+                ProtectedMasterLibrary.ReOpen();
+
+                WBLogging.RecordsTypes.HighLevel("Have re-opened the whole ProtectedMasterLibrary object - now re-getting the SPFolder:");
+
+                protectedLibraryRootFolder = ProtectedMasterLibrary.List.RootFolder;
+                actualDestinationFolder = protectedLibraryRootFolder.WBxGetFolderPath(fullFilingPath);
+            }
+              */
+            
+     
             if (ProtectedMasterLibrary.Web.WBxFileExists(actualDestinationFolder, filename))
             {
                 filename = ProtectedMasterLibrary.Web.WBxMakeFilenameUnique(actualDestinationFolder, filename);

WorkBoxFramework/Classes/WBRecordsLibrary.cs

@@ -152,6 +152,26 @@ public WBRecordsLibrary(WBRecordsLibraries libraries, String url, String protect
 
 
         #region Methods
+
+        public void ReOpen()
+        {
+            if (!IsOpen || !_openedByThisObject || _site == null || _web == null || String.IsNullOrEmpty(_url))
+            {
+                WBLogging.RecordsTypes.Unexpected("You can't re-open a WBRecordsLibrary if it is not already open - and opened by this object");
+                throw new Exception("You can't re-open a WBRecordsLibrary if it is not already open");
+            }
+
+            _web.Dispose();
+            _web = null;
+
+            _site.Dispose();
+            _site = null;
+
+            _isOpen = false;
+
+            Open();
+        }
+
         public bool Open()
         {
             if (IsOpen) return false;

WorkBoxFramework/Classes/WBRecordsManager.cs

@@ -226,13 +226,29 @@ public WBPublishingProcess PublishDocument(WBPublishingProcess process)
             }
             catch (Exception e)
             {
-                feedback.Failed("Something went wrong with the publishing process", e);
-                WBLogging.Debug("Something went wrong with the publishing process");
+                feedback.AddFeedback("Something went wrong with first attempt to publish document");
+                feedback.AddException(e);
 
-                process.CurrentItemFailed();
-                return process;
+                WBLogging.RecordsTypes.Unexpected("Something went wrong with first attempt to publish document", e);
             }
 
+            if (newRecord == null)
+            {
+                WBLogging.RecordsTypes.Unexpected("Making a second attempt to publish document");
+
+                try
+                {
+                    newRecord = Libraries.DeclareNewRecord(feedback, _callingUserLogin, document, recordToReplace, process.ReplaceAction, process.ExtraMetadata);
+                }
+                catch (Exception e)
+                {
+                    feedback.Failed("Something went wrong with the second attempt to publish document", e);
+                    WBLogging.RecordsTypes.Unexpected("Something went wrong with the second attempt to publish document", e);
+
+                    process.CurrentItemFailed();
+                    return process;
+                }
+            }
 
             WBLogging.Debug("WBRecordsManager.PublishDocument(): Declared new record");
             feedback.Success();

WorkBoxFramework/Package/Package.package

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<package xmlns:dm0="http://schemas.microsoft.com/VisualStudio/2008/DslTools/Core" dslVersion="1.0.0.0" Id="122d1e78-156a-4d31-adc1-66fee258b162" solutionId="122d1e78-156a-4d31-adc1-66fee258b162" resetWebServer="false" name="WorkBoxFramework v0.9.9.3c" xmlns="http://schemas.microsoft.com/VisualStudio/2008/SharePointTools/PackageModel">
+<package xmlns:dm0="http://schemas.microsoft.com/VisualStudio/2008/DslTools/Core" dslVersion="1.0.0.0" Id="122d1e78-156a-4d31-adc1-66fee258b162" solutionId="122d1e78-156a-4d31-adc1-66fee258b162" resetWebServer="false" name="WorkBoxFramework v0.9.9.4c" xmlns="http://schemas.microsoft.com/VisualStudio/2008/SharePointTools/PackageModel">
   <assemblies>
     <customAssembly location="Newtonsoft.Json.dll" deploymentTarget="GlobalAssemblyCache" sourcePath="Include\Newtonsoft.Json.dll" />
   </assemblies>