CHANGE: value of false dynamic function refinement is none, not false (as native code expects none, which is cheaper to compare)

Author: Oldes

src/core/c-do.c

@@ -777,7 +777,7 @@ x*/	static REBINT Do_Args_Light(REBVAL *func, REBVAL *path, REBSER *block, REBCN
 				if (SAME_SYM(path, args)) {
 					value = Get_Var(path);
 					useArgs = IS_TRUE(value);
-					SET_LOGIC(DS_VALUE(ds), useArgs);
+					if (useArgs) SET_TRUE(DS_VALUE(ds));
 					path++;				// remove processed refinement
 					continue;
 				}
@@ -789,7 +789,7 @@ x*/	static REBINT Do_Args_Light(REBVAL *func, REBVAL *path, REBSER *block, REBCN
 					if (IS_REFINEMENT(args) && VAL_WORD_CANON(args) == VAL_WORD_CANON(path)) {
 						value = Get_Var(path);
 						useArgs = IS_TRUE(value);
-						SET_LOGIC(DS_VALUE(ds), useArgs);
+						if (useArgs) SET_TRUE(DS_VALUE(ds));
 						path++;				// remove processed refinement
 						break;
 					}

src/tests/units/evaluation-test.r3

@@ -1161,7 +1161,7 @@ Rebol [
 	--test-- "dyn-ref-8"
 		ref: no
 		--assert (dyn-ref-fun/:ref 10 * 9 "hello" 789)
-			== [90 "hello" #[false] #[none] #[none] #[none] #[none] #[none]]
+			== [90 "hello" #[none] #[none] #[none] #[none] #[none] #[none]]
 
 	--test-- "dyn-ref-9"
 		ref: ref2: yes
@@ -1171,12 +1171,12 @@ Rebol [
 	--test-- "dyn-ref-10"
 		ref: no ref2: yes
 		--assert (dyn-ref-fun/:ref/:ref2 10 * 9 "hello" 789)
-			== [90 "hello" #[false] #[none] #[true] #[none] #[none] #[none]]
+			== [90 "hello" #[none] #[none] #[true] #[none] #[none] #[none]]
 
 	--test-- "dyn-ref-11"
 		ref: no ref2: ref3: yes
 		--assert (dyn-ref-fun/:ref/:ref2/:ref3 10 * 9 "hello" 789 6 7)
-			== [90 "hello" #[false] #[none] #[true] #[true] 6 7]
+			== [90 "hello" #[none] #[none] #[true] #[true] 6 7]
 
 	--test-- "dyn-ref-12"		
 		dyn-ref-12-obj: context [
@@ -1186,7 +1186,7 @@ Rebol [
 		    bar: func [/local ref][
 		        ref: no
 				--assert (foo/:ref 10 * 9 "hello" 789)
-				== [90 "hello" #[false] #[none] #[none] #[none] #[none] #[none]]
+				== [90 "hello" #[none] #[none] #[none] #[none] #[none] #[none]]
 
 		        ref: yes
 				--assert (foo/:ref 10 * 9 "hello" 789)

src/tests/units/func-test.r3

@@ -29,19 +29,19 @@ Rebol [
 	ref1: yes --assert all [error? e: try [fce/:ref1 "a"   ] e/id = 'no-arg]
 	ref1: off --assert all [error? e: try [fce/:ref1 "a"   ] e/id = 'no-arg]
 	ref1: yes --assert all [error? e: try [fce/:ref1 "a" ""] e/id = 'expect-arg]
-	ref1: off --assert (fce/:ref1 "a" "")    == ["a" #[false] #[none] #[none] #[none] #[none]]
-	ref1: yes --assert (fce/:ref1 "a" 1)     == ["a" #[true]  1       #[none] #[none] #[none]]
-	ref1: off --assert (fce/:ref1 "a" 1)     == ["a" #[false] #[none] #[none] #[none] #[none]]
-	ref1: yes --assert all [(fce/:ref1 "a" x: 1 + 1) == ["a" #[true]  2       #[none] #[none] #[none]] x == 2]
-	ref1: off --assert all [(fce/:ref1 "a" x: 1 + 1) == ["a" #[false] #[none] #[none] #[none] #[none]] x == 2]
+	ref1: off --assert (fce/:ref1 "a" "")    == ["a" #[none] #[none] #[none] #[none] #[none]]
+	ref1: yes --assert (fce/:ref1 "a" 1)     == ["a" #[true]  1      #[none] #[none] #[none]]
+	ref1: off --assert (fce/:ref1 "a" 1)     == ["a" #[none] #[none] #[none] #[none] #[none]]
+	ref1: yes --assert all [(fce/:ref1 "a" x: 1 + 1) == ["a" #[true]  2      #[none] #[none] #[none]] x == 2]
+	ref1: off --assert all [(fce/:ref1 "a" x: 1 + 1) == ["a" #[none] #[none] #[none] #[none] #[none]] x == 2]
 	ref1: yes ref2: yes --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[true] 2 #[true] x y]
 	ref1: yes ref2: yes --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[true] 2 #[true] x y]
-	ref1: yes ref2: off --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[true] 2 #[false] #[none] #[none]]
-	ref1: yes ref2: off --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[true] 2 #[false] #[none] #[none]]
-	ref1: off ref2: yes --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[false] #[none] #[true] x y]
-	ref1: off ref2: yes --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[false] #[none] #[true] x y]
-	ref1: off ref2: off --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[false] #[none] #[false] #[none] #[none]]
-	ref1: off ref2: off --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[false] #[none] #[false] #[none] #[none]]
+	ref1: yes ref2: off --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[true] 2 #[none] #[none] #[none]]
+	ref1: yes ref2: off --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[true] 2 #[none] #[none] #[none]]
+	ref1: off ref2: yes --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[none] #[none] #[true] x y]
+	ref1: off ref2: yes --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[none] #[none] #[true] x y]
+	ref1: off ref2: off --assert (fce/:ref1/:ref2 "a" 1 + 1 x y) == ["a" #[none] #[none] #[none] #[none] #[none]]
+	ref1: off ref2: off --assert (fce/:ref2/:ref1 "a" x y 1 + 1) == ["a" #[none] #[none] #[none] #[none] #[none]]
 
 ===end-group===