FIX: writing data to smtp scheme must use chunks not higher than 16KiB (TLS limitation)

Author: Oldes

src/mezz/prot-smtp.reb

@@ -69,7 +69,7 @@ where's my kibble?}]
 
 system/options/log/smtp: 2
 
-bufsize: 32000 ;-- use a write buffer of 32k for sending large attachments
+bufsize: 16384 ;-- use a write buffer of 16KiB (maximum TLS record size!) for sending large attachments
 
 mail-obj: make object! [ 
 	from: 
@@ -320,7 +320,7 @@ sync-smtp-handler: function [event][
 			switch/default state [
 				SENDING [
 					either not empty? ptr: smtp-ctx/mail/message [
-						sys/log/debug 'SMTP ["Sending "  min bufsize length? ptr " bytes of " length? ptr ]
+						sys/log/more 'SMTP ["Sending"  min bufsize length? ptr "bytes of" length? ptr ]
 						write client to binary! take/part ptr bufsize
 					][
 						sys/log/debug 'SMTP "Sending ends."
@@ -478,6 +478,8 @@ sys/make-scheme [
 				close port
 				wait [port 0.1]
 				do error
+				port/state: 'ERROR
+				true
 			]
 			close [
 				port/state: 'CLOSE

src/mezz/prot-tls.reb

@@ -2145,10 +2145,23 @@ TLS-client-awake: function [event [event!]][
 			return true
 		]
 		error [
-			if all [ctx ctx/state = 'lookup][
-				ctx/error: make error! [
-					code: 500 type: 'access id: 'cannot-open
-					arg1: TCP-port/spec/ref
+			unless ctx/error [
+				ctx/error: case [
+					ctx/state = 'lookup [
+						make error! [
+							code: 500 type: 'access id: 'cannot-open
+							arg1: TCP-port/spec/ref
+						]
+					]
+					'else [
+						;@@ needs better error (unknown reason)
+						; So far this error is used, when we try to write
+						; application data larger than 16KiB!
+						make error! [
+							code: 500 type: 'access id: 'protocol
+							arg1: TCP-port/spec/ref
+						]
+					]
 				]
 			]
 			send-event 'error TLS-port
@@ -2284,7 +2297,8 @@ do-TLS-write: func[port [port!] value [any-type!] /local ctx][
 	log-debug "WRITE"
 	ctx: port/extra
 	if ctx/protocol = 'APPLICATION [
-
+		;@@ FIXME: size limit for application data is 16KiB,
+		;@@ else server closes connection, which is not detected!
 		binary/init ctx/out none ;resets the output buffer
 		application-data ctx :value