FEAT: implemented proper ask/hide and input/hide

That was not working well on Windows (with enabled virtual terminal processing), now it successfully hides user input.

As a bonus this change contain a way how to turn off read-line console input and enter use the console as a key-stroke (and mouse as well) input. Simple use example is available here:
https://gist.github.com/Oldes/face8a5790df7121a78ba606a3e150f4

Author: Oldes

src/boot/modes.r

@@ -1,6 +1,6 @@
 REBOL [
 	System: "REBOL [R3] Language Interpreter and Run-time Environment"
-	Title: "Port modes"
+	Title: "Port & console modes"
 	Rights: {
 		Copyright 2012 REBOL Technologies
 		REBOL is a trademark of REBOL Technologies
@@ -11,12 +11,19 @@ REBOL [
 	}
 ]
 
-owner-read
-owner-write
-owner-execute
-group-read
-group-write
-group-execute
-world-read
-world-write
-world-execute
+*port-modes* [
+	owner-read
+	owner-write
+	owner-execute
+	group-read
+	group-write
+	group-execute
+	world-read
+	world-write
+	world-execute
+]
+
+*console-modes* [
+	echo
+	line
+]

src/boot/words.r

@@ -229,7 +229,8 @@ on-top
 hidden
 owner
 
-*port-modes*
+*port-modes*     ;@@ modes are defined in modes.r file and these
+*console-modes*  ;@@ placeholders are replaced here by make-boot.r script
 
 bits
 crash

src/core/n-io.c

@@ -409,11 +409,13 @@ static REBSER *Read_All_File(char *fname)
 
 	val = OFV(port, STD_PORT_ACTOR);
 	if (IS_NATIVE(val)) {
+		//  Makes the port object fully consistent with internal native structures (e.g. the actual length of data read).
 		Do_Port_Action(port, A_UPDATE); // uses current stack frame
 	}
 
 	val = OFV(port, STD_PORT_AWAKE);
 	if (ANY_FUNC(val)) {
+		// Calls the port's awake function with the event as an argument.
 		val = Apply_Func(0, val, D_ARG(2), 0);
 		if (!(IS_LOGIC(val) && VAL_LOGIC(val))) return R_FALSE;
 	}

src/core/p-console.c

@@ -57,7 +57,9 @@
 	arg = D_ARG(2);
 	*D_RET = *D_ARG(1);
 
-	req = Use_Port_State(port, RDI_STDIO, sizeof(REBREQ));
+	//O: known limitation: works only with default system's imput port (not for custom console ports) 
+	req = Host_Lib->std_io;
+	req->port = port;
 
 	switch (action) {
 
@@ -85,17 +87,22 @@
 		if (req->actual == 1 && req->data[0] == '\x1B') return R_NONE; // CTRL-C
 
 #ifdef TO_WINDOWS
-		if (req->actual > 1) req->actual -= 2; // remove CRLF from tail
+		if (req->actual > 1 && GET_FLAG(req->modes, RDM_READ_LINE)) req->actual -= 2; // remove CRLF from tail
 #else
 		if (req->actual > 0) req->actual -= 1; // remove LF from tail
 #endif
 
 		Set_Binary(ds, Copy_Bytes(req->data, req->actual));
 		break;
 
+	case A_UPDATE:
+		// do nothing here, no wake-up, events should be handled by user defined port's awake function
+		// ==>> SYSTEM/PORTS/INPUT/SCHEME/AWAKE
+		return R_NONE;
+
 	case A_OPEN:
 		// ?? why???
-		//if (OS_DO_DEVICE(req, RDC_OPEN)) Trap_Port(RE_CANNOT_OPEN, port);
+		if (OS_DO_DEVICE(req, RDC_OPEN)) Trap_Port(RE_CANNOT_OPEN, port, req->error);
 		SET_OPEN(req);
 		break;
 
@@ -108,6 +115,18 @@
 		if (IS_OPEN(req)) return R_TRUE;
 		return R_FALSE;
 
+	case A_MODIFY:
+		if (IS_WORD(arg)
+			&& (VAL_WORD_CANON(arg) == SYM_ECHO || VAL_WORD_CANON(arg) == SYM_LINE)
+		) {
+			spec = D_ARG(3);
+			if (!IS_LOGIC(spec)) Trap2(RE_INVALID_VALUE_FOR, spec, arg);
+			req->modify.mode = (VAL_WORD_CANON(arg) == SYM_ECHO) ? MODE_CONSOLE_ECHO : MODE_CONSOLE_LINE;
+			req->modify.value = VAL_LOGIC(spec);
+			OS_DO_DEVICE(req, RDC_MODIFY);
+		} else Trap1(RE_BAD_FILE_MODE, arg);
+		return R_ARG3;
+
 	case A_QUERY:
 		spec = Get_System(SYS_STANDARD, STD_CONSOLE_INFO);
 		if (!IS_OBJECT(spec)) Trap_Arg(spec);

src/core/t-event.c

@@ -230,6 +230,9 @@
 		else if (IS_EVENT_MODEL(value, EVM_CALLBACK)) {
 			*val = *Get_System(SYS_PORTS, PORTS_CALLBACK);
 		}
+		else if (IS_EVENT_MODEL(value, EVM_CONSOLE)) {
+			*val = *Get_System(SYS_PORTS, PORTS_INPUT);
+		}
 		else {
 			// assumes EVM_DEVICE
 			// Event holds the IO-Request, which has the PORT:

src/core/t-port.c

@@ -89,6 +89,7 @@
 	case A_CREATE:
 	case A_DELETE:
 	case A_RENAME:
+	case A_MODIFY:
 		value = As_Port(value);
 	case A_UPDATE:
 	default:

src/include/reb-device.h

@@ -108,6 +108,7 @@ enum {
 
 enum {
 	RDM_NULL,		// Null device
+	RDM_READ_LINE,
 };
 
 #pragma pack(4)
@@ -191,6 +192,10 @@ struct rebol_devreq {
 			u32 device_in;  // requested device ID (1-based; 0 = none)
 			u32 device_out;
 		} midi;
+		struct {
+			u32 mode;
+			u32 value;
+		} modify;
 	};
 };
 #pragma pack()

src/include/reb-event.h

@@ -73,6 +73,7 @@ enum {
 	EVM_GUI,		// GUI event uses system/view/event/port
 	EVM_CALLBACK,	// Callback event uses system/ports/callback port
 	EVM_MIDI,		// event holds midi port pointer
+	EVM_CONSOLE,    // native console events
 };
 
 // Special messages

src/include/reb-host.h

@@ -41,3 +41,5 @@
 
 #include "reb-gob.h"
 #include "reb-lib.h"
+
+#include "tmp-portmodes.h"

src/include/sys-core.h

@@ -119,6 +119,7 @@ typedef struct rebol_mold {
 #include "host-lib.h"
 #include "sys-stack.h"
 #include "sys-state.h"
+#include "tmp-portmodes.h"
 
 /***********************************************************************
 **

src/mezz/mezz-files.r

@@ -62,31 +62,32 @@ clean-path: func [
 	reverse out
 ]
 
-input: function [
+input: func [
 	{Inputs a string from the console.}
-;	/hide "Mask input with a * character"
+	/hide "Turns off echoing inputs"
+	/local line port
 ][
+	port: system/ports/input
 	if any [
-		not port? system/ports/input
-		not open? system/ports/input
+		not port? port
+		not open? port
 	][
-		system/ports/input: open [scheme: 'console]
+		system/ports/input: port: open [scheme: 'console]
 	]
-	if line: read system/ports/input [ line: to string! line ]
+	if hide [ modify port 'echo false ]
+	if line: read port [ line: to string! line ]
+	if hide [ modify port 'echo true ]
 	line
 ]
 
 ask: func [
 	"Ask the user for input."
 	question [series!] "Prompt to user"
 	/hide "Turns off echoing inputs"
+	/char "Waits only on single key press and returns char as a result"
 ][
 	prin question
-	either hide [
-		prin  "^[[8m"  ; ANSI conceal command
-		also input
-		print "^[[28m" ; ANSI reveal command
-	][	input ]
+	also apply :input [hide] prin LF
 ]
 
 confirm: func [

src/mezz/sys-ports.r

@@ -196,8 +196,12 @@ init-schemes: func [
 				][
 					remove event-list ;avoid event overflow caused by wake-up recursively calling into wait
 					if wake-up port event [
-						; Add port to wake list:
+						;@@ `wake-up` function is natively calling UPDATE action on current port
+						;@@ this is processed in port's actor function,                         
+						;@@ for example in `Console_Actor` in p-console.c file                  
+						;@@ If result of this action is truethy, port is waked up here          
 						;print ["==System-waked:" port/spec/ref]
+						; Add port to wake list:
 						unless find waked port [append waked port]
 					]
 					++ n-event
@@ -229,6 +233,11 @@ init-schemes: func [
 	make-scheme [
 		title: "Console Access"
 		name: 'console
+		;awake: func [event] [
+		;	print ["Console event:" event/type mold event/key event/offset]
+		;	;probe event
+		;	false
+		;]
 	]
 
 	make-scheme [

src/os/host-main.c

@@ -90,7 +90,7 @@ extern void Init_Ext_Test(void);	// see: host-ext-test.c
 #endif
 
 // Host bare-bones stdio functs:
-extern void Open_StdIO(void);
+extern REBREQ *Open_StdIO();
 extern void Close_StdIO(void);
 extern void Put_Str(REBYTE *buf);
 extern REBYTE *Get_Str(void);
@@ -268,10 +268,11 @@ int main(int argc, char **argv) {
 #endif
 	REBYTE vers[8];
 	REBINT n;
+	REBREQ *std_io;
 
 	// Must be done before an console I/O can occur. Does not use reb-lib,
 	// so this device should open even if there are other problems.
-	Open_StdIO();  // also sets up interrupt handler
+	std_io = Open_StdIO();  // also sets up interrupt handler
 
 	Host_Lib = &Host_Lib_Init;
 
@@ -290,6 +291,7 @@ int main(int argc, char **argv) {
 	if (!Host_Lib) Host_Crash("Missing host lib");
 	// !!! Second part will become vers[2] < RL_REV on release!!!
 	if (vers[1] != RL_VER || vers[2] != RL_REV) Host_Crash("Incompatible reb-lib DLL");
+	Host_Lib->std_io = std_io;
 	n = RL_Init(&Main_Args, Host_Lib);
 	if (n == 1) Host_Crash("Host-lib wrong size");
 	if (n == 2) Host_Crash("Host-lib wrong version/checksum");

src/os/host-stdio.c

@@ -49,7 +49,9 @@
 void Host_Crash(char *reason);
 
 // Temporary globals: (either move or remove?!)
-REBREQ Std_IO_Req;
+// O: where it should be moved?
+// O: as the Std_IO_Req is shared with lib (DLL), I'm now storing it also in Host_Lib struct
+static REBREQ Std_IO_Req;
 static REBYTE *inbuf;
 static REBCNT inbuf_len = 32*1024;
 
@@ -105,7 +107,7 @@ static int Fetch_Buf()
 
 /***********************************************************************
 **
-*/	void Open_StdIO(void)
+*/	REBREQ *Open_StdIO()
 /*
 **		Open REBOL's standard IO device. This same device is used
 **		by both the host code and the R3 DLL itself.
@@ -125,6 +127,7 @@ static int Fetch_Buf()
 
 	inbuf = OS_Make(inbuf_len);
 	inbuf[0] = 0;
+	return &Std_IO_Req;
 }
 
 /***********************************************************************
@@ -152,6 +155,13 @@ static int Fetch_Buf()
 {
 	REBYTE *line;
 
+	// make sure that we are in LINE reading mode!
+	if (!GET_FLAG(Std_IO_Req.modes, RDM_READ_LINE)) {
+		// if not, set it back
+		Std_IO_Req.modify.mode = RDM_READ_LINE;
+		Std_IO_Req.modify.value = TRUE;
+		OS_Do_Device(&Std_IO_Req, RDC_MODIFY);
+	}
 	if ((line = Get_Next_Line())) return line;
 
 	if (Fetch_Buf()) return Get_Next_Line();

src/os/posix/dev-stdio.c

@@ -298,6 +298,31 @@ static void Close_Stdio(void)
 	return DR_DONE;
 }
 
+/***********************************************************************
+**
+*/	DEVICE_CMD Modify_IO(REBREQ *req)
+/*
+**		Change console's mode.
+**
+***********************************************************************/
+{
+	long total;
+	if (req->modify.mode == MODE_CONSOLE_ECHO) {
+		if (Std_Out >= 0) {
+			if(req->modify.value) {
+				total = write(Std_Out, "\x1B[28m", 5);
+			} else {
+				total = write(Std_Out, "\x1B[8m", 4);
+			}
+			if (total < 0) {
+				req->error = errno;
+				return DR_ERROR;
+			}
+		}
+	}
+	return DR_DONE;
+}
+
 /***********************************************************************
 **
 */	DEVICE_CMD Open_Echo(REBREQ *req)
@@ -340,7 +365,7 @@ static DEVICE_CMD_FUNC Dev_Cmds[RDC_MAX] =
 	0,	// poll
 	0,	// connect
 	Query_IO,
-	0,	// modify
+	Modify_IO,	// modify
 	Open_Echo,	// CREATE used for opening echo file
 };