FIX: don't allow making a module! from integer! and map!

resolves: Oldes/Rebol-issues#1551

Author: Oldes

src/core/t-object.c

@@ -343,20 +343,24 @@ static REBSER *Trim_Object(REBSER *obj)
 				break; // returns value
 			}
 
-			// make object! 10
-			if (IS_NUMBER(arg)) {
-				n = Int32s(arg, 0);
-				obj = Make_Frame(n);
-				break; // returns obj
-			}
+			// Allow only object! to be made from from map! or number! spec
+			if (type == REB_OBJECT) {
 
-			// make object! map!
-			if (IS_MAP(arg)) {
-				obj = Map_To_Object(VAL_SERIES(arg));
-				break; // returns obj
+				// make object! 10
+				if (IS_NUMBER(arg)) {
+					n = Int32s(arg, 0);
+					obj = Make_Frame(n);
+					break; // returns obj
+				}
+
+				// make object! map!
+				if (IS_MAP(arg)) {
+					obj = Map_To_Object(VAL_SERIES(arg));
+					break; // returns obj
+				}
 			}
 
-			//if (IS_NONE(arg)) {obj = Make_Frame(0); break;}
+			//if (IS_NONE(arg)) {obj = Make_Frame(0); break;} // removed by design!
 
 			Trap_Make(type, arg);
 		}

src/tests/units/module-test.r3

@@ -116,6 +116,24 @@ supplement system/options/module-paths join what-dir %units/files/
 			error? err: try [module [type: :print][]]
 			err/id = 'wrong-type
 		]
+	--test-- "make module! integer!" ; not allowed
+	;@@ https://github.com/Oldes/Rebol-issues/issues/1551
+		--assert all [
+			error? err: try [make module! 10]
+			err/id = 'bad-make-arg
+		]
+	--test-- "make module! map!" ; not allowed
+	;@@ https://github.com/Oldes/Rebol-issues/issues/1551
+		--assert all [
+			error? err: try [make module! #(a: 1)]
+			err/id = 'bad-make-arg
+		]
+	--test-- "make module! object!" ; not allowed
+	;@@ https://github.com/Oldes/Rebol-issues/issues/1551
+		--assert all [
+			error? err: try [make module! context [a: 1]]
+			err/id = 'bad-make-arg
+		]
 
 ===end-group===