FIX: echo does not error on bad path

resolves: Oldes/Rebol-issues#693

Author: Oldes

src/core/d-print.c

@@ -512,12 +512,12 @@ static REBREQ *Req_SIO;
 
 /***********************************************************************
 **
-*/	REBFLG Echo_File(REBCHR *file)
+*/	REBINT Echo_File(REBCHR *file)
 /*
 ***********************************************************************/
 {
 	Req_SIO->file.path = file;
-	return (DR_ERROR != OS_DO_DEVICE(Req_SIO, RDC_CREATE));
+	return OS_DO_DEVICE(Req_SIO, RDC_CREATE);
 }
 
 

src/core/n-io.c

@@ -82,6 +82,7 @@ static REBSER *Read_All_File(char *fname)
 {
 	REBVAL *val = D_ARG(1);
 	REBSER *ser = 0;
+	REBINT err;
 
 	Echo_File(0);
 
@@ -91,7 +92,11 @@ static REBSER *Read_All_File(char *fname)
 		ser = To_Local_Path("output.txt", 10, FALSE, TRUE);
 
 	if (ser) {
-		if (!Echo_File((REBCHR*)(ser->data))) Trap1(RE_CANNOT_OPEN, val);
+		err = Echo_File((REBCHR *)(ser->data));
+		if (err != DR_DONE) {
+			SET_INTEGER(D_RET, -err);
+			Trap2(RE_CANNOT_OPEN, val, D_RET);
+		}
 	}
 
 	return R_RET;

src/tests/units/file-test.r3

@@ -130,4 +130,17 @@ secure [%/ allow]
 
 ===end-group===
 
+
+===start-group=== "ECHO"
+	--test-- "echo test"
+		echo %echo-result print 1 echo none
+		--assert "1^/" = read/string %echo-result
+
+	--test-- "echo failed"
+	;@@ https://github.com/Oldes/Rebol-issues/issues/834
+		--assert all [error? e: try [echo %not-existing-dir/foo] e/id = 'cannot-open]
+===end-group===
+
+echo %/r/sss/xxxx
+
 ~~~end-file~~~