FEAT: avoiding series copy where possible (like in append "" 1)

Author: Oldes

src/core/f-modify.c

@@ -3,7 +3,7 @@
 **  REBOL [R3] Language Interpreter and Run-time Environment
 **
 **  Copyright 2012 REBOL Technologies
-**  Copyright 2012-2022 Rebol Open Source Contributors
+**  Copyright 2012-2024 Rebol Open Source Contributors
 **  REBOL is a trademark of REBOL Technologies
 **
 **  Licensed under the Apache License, Version 2.0 (the "License");
@@ -180,7 +180,7 @@
 		src_ser = Form_Tight_Block(src_val);
 	}
 	else if (!ANY_STR(src_val) || IS_TAG(src_val)) {
-		src_ser = Copy_Form_Value(src_val, 0);
+		src_ser = Form_Value(src_val, 0, FALSE);
 	}
 
 	// Use either new src or the one that was passed:

src/core/n-io.c

@@ -116,7 +116,7 @@ static REBSER *Read_All_File(char *fname)
 **
 ***********************************************************************/
 {
-	Set_String(D_RET, Copy_Form_Value(D_ARG(1), 0));
+	Set_String(D_RET, Form_Value(D_ARG(1), 0, TRUE));
 	return R_RET;
 }
 
@@ -833,7 +833,7 @@ static REBSER *Read_All_File(char *fname)
 			} else if (ANY_STR(param)) {
 				argv[i] = Val_Str_To_OS(param);
 			} else if (IS_WORD(param)) {
-				Set_Series(REB_STRING, D_RET, Copy_Form_Value(param, TRUE));
+				Set_Series(REB_STRING, D_RET, Form_Value(param, TRUE, TRUE));
 				argv[i] = Val_Str_To_OS(D_RET);
 			} else {
 				Trap_Arg(param);
@@ -1201,7 +1201,7 @@ static REBSER *Read_All_File(char *fname)
 
 	Check_Security(SYM_ENVR, POL_READ, arg);
 
-	if (ANY_WORD(arg)) Set_String(arg, Copy_Form_Value(arg, 0));
+	if (ANY_WORD(arg)) Set_String(arg, Form_Value(arg, 0, FALSE));
 	cmd = Val_Str_To_OS(arg);
 
 	lenplus = OS_GET_ENV(cmd, (REBCHR*)0, 0);
@@ -1231,7 +1231,7 @@ static REBSER *Read_All_File(char *fname)
 
 	Check_Security(SYM_ENVR, POL_WRITE, arg1);
 
-	if (ANY_WORD(arg1)) Set_String(arg1, Copy_Form_Value(arg1, 0));
+	if (ANY_WORD(arg1)) Set_String(arg1, Form_Value(arg1, 0, FALSE));
 	cmd = Val_Str_To_OS(arg1);
 
 	if (ANY_STR(arg2)) {

src/core/s-mold.c

@@ -1460,7 +1460,7 @@ STOID Mold_Error(REBVAL *value, REB_MOLD *mold, REBFLG molded)
 
 /***********************************************************************
 **
-*/  REBSER *Copy_Form_Value(REBVAL *value, REBCNT opts)
+*/  REBSER *Form_Value(REBVAL *value, REBCNT opts, REBFLG copy)
 /*
 **		Form a value based on the mold opts provided.
 **
@@ -1471,7 +1471,7 @@ STOID Mold_Error(REBVAL *value, REB_MOLD *mold, REBFLG molded)
 	mo.opts = opts;
 	Reset_Mold(&mo);
 	Mold_Value(&mo, value, 0);
-	return Copy_String(mo.series, 0, -1);
+	return copy ? Copy_String(mo.series, 0, -1) : mo.series;
 }
 
 

src/core/t-string.c

@@ -3,7 +3,7 @@
 **  REBOL [R3] Language Interpreter and Run-time Environment
 **
 **  Copyright 2012 REBOL Technologies
-**  Copyright 2012-2023 Rebol Open Source Developers
+**  Copyright 2012-2024 Rebol Open Source Developers
 **  REBOL is a trademark of REBOL Technologies
 **
 **  Licensed under the Apache License, Version 2.0 (the "License");
@@ -173,7 +173,7 @@ static REBSER *make_string(REBVAL *arg, REBOOL make)
 	}
 	// MAKE/TO <type> <any-word>
 	else if (ANY_WORD(arg) || ANY_PATH(arg)) {
-		ser = Copy_Form_Value(arg, TRUE);
+		ser = Form_Value(arg, TRUE, TRUE);
 		//ser = Append_UTF8(0, Get_Word_Name(arg), -1);
 	}
 	// MAKE/TO <type> #"A"
@@ -186,7 +186,7 @@ static REBSER *make_string(REBVAL *arg, REBOOL make)
 //		ser = Make_Binary(0);
 //	}
 	else
-		ser = Copy_Form_Value(arg, 1<<MOPT_TIGHT);
+		ser = Form_Value(arg, 1<<MOPT_TIGHT, TRUE);
 
 	return ser;
 }
@@ -636,7 +636,7 @@ static struct {
 		else {
 			if (IS_CHAR(arg) || IS_BITSET(arg)) len = 1;
 			else if (!ANY_STR(arg)) {
-				Set_String(arg, Copy_Form_Value(arg, 0));
+				Set_String(arg, Form_Value(arg, 0, FALSE));
 			}
 		}