FEAT: added possibility to set/clear BREAK, DATA-TERMINAL-READY and REQUEST-TO-SEND serial signals (on Windows so far)

Author: Oldes

src/boot/modes.reb

@@ -28,3 +28,10 @@ REBOL [
 	line
 	error
 ]
+
+*serial-modes* [
+	brk ;break
+	dtr ;data-terminal-ready
+	rts ;request-to-send
+]
+

src/boot/words.reb

@@ -257,6 +257,7 @@ owner
 
 *port-modes*     ;@@ modes are defined in modes.r file and these
 *console-modes*  ;@@ placeholders are replaced here by make-boot.r script
+*serial-modes*
 
 local-ip
 local-port

src/core/p-serial.c

@@ -226,6 +226,22 @@
 			SET_CLOSED(req);
 		}
 		break;
+	case A_MODIFY:
+		arg = D_ARG(2);
+		if (IS_WORD(arg)) {
+			switch (VAL_WORD_CANON(arg)) {
+			case SYM_BRK:  req->modify.mode = 1; break;
+			case SYM_RTS:  req->modify.mode = 2; break;
+			case SYM_DTR:  req->modify.mode = 3; break;
+			default: Trap1(RE_BAD_FILE_MODE, arg);
+			}
+			spec = D_ARG(3);
+			if (!IS_LOGIC(spec)) Trap2(RE_INVALID_VALUE_FOR, spec, arg);
+			req->modify.value = VAL_LOGIC(spec);
+			OS_DO_DEVICE(req, RDC_MODIFY);
+		}
+		else Trap1(RE_BAD_FILE_MODE, arg);
+		return R_ARG3;
 
 	default:
 		Trap_Action(REB_PORT, action);

src/os/win32/dev-serial.c

@@ -129,7 +129,7 @@ static REBINT Set_Serial_Settings(HANDLE h, REBREQ *req)
 		return DR_ERROR;
 	}
 
-	JOIN_STR(fullpath,req->serial.path,MAX_SERIAL_DEV_PATH);
+	JOIN_STR(fullpath,req->serial.path,MAX_SERIAL_DEV_PATH-5); // 5 because of "\\.\" and terminating byte
 
 	h = CreateFile(fullpath, GENERIC_READ|GENERIC_WRITE, 0, NULL,OPEN_EXISTING, 0, NULL );
 	if (h == INVALID_HANDLE_VALUE) {
@@ -232,7 +232,7 @@ static REBINT Set_Serial_Settings(HANDLE h, REBREQ *req)
 	}
 
 #ifdef DEBUG_SERIAL
-	printf("write %d ret: %d\n", req->length, req->actual);
+	printf("write %d wrote: %lu ret: %d\n", req->length, result,  req->actual);
 #endif
 
 	if (result < 0) {
@@ -241,7 +241,7 @@ static REBINT Set_Serial_Settings(HANDLE h, REBREQ *req)
 		return DR_ERROR;
 	}
 	req->actual += result;
-	req->data += result;
+	//req->data += result;
 	if (req->actual >= req->length) {
 		Signal_Device(req, EVT_WROTE);
 		return DR_DONE;
@@ -270,6 +270,21 @@ static REBINT Set_Serial_Settings(HANDLE h, REBREQ *req)
 	return DR_DONE;
 }
 
+/***********************************************************************
+**
+*/	DEVICE_CMD Modify_Serial(REBREQ *req)
+/*
+***********************************************************************/
+{
+	boolean value = req->modify.value;
+	switch (req->modify.mode) {
+	case 1:	EscapeCommFunction(req->handle, value ? SETBREAK : CLRBREAK); break;
+	case 2:	EscapeCommFunction(req->handle, value ? SETRTS : CLRRTS); break; // (request-to-send) signal
+	case 3:	EscapeCommFunction(req->handle, value ? SETDTR : CLRDTR); break; // (data-terminal-ready) signal
+	}
+	return DR_DONE;
+}
+
 
 /***********************************************************************
 **
@@ -287,7 +302,7 @@ static DEVICE_CMD_FUNC Dev_Cmds[RDC_MAX] = {
 	0,  // poll
 	0,	// connect
 	Query_Serial,
-	0,	// modify
+	Modify_Serial,
 	0,	// create
 	0,	// delete
 	0	// rename