Skip to content

Commit 2b53189

Browse files
committed
CHANGE: don't allow binary input for set operations (does not work anyway)
related to: Oldes/Rebol-issues#1978
1 parent 707c373 commit 2b53189

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

src/boot/natives.reb

+9-9
Original file line numberDiff line numberDiff line change
@@ -453,43 +453,43 @@ entab: native [
453453

454454
difference: native [
455455
{Returns the special difference of two values.}
456-
set1 [block! string! binary! bitset! date! typeset! map!] "First data set"
457-
set2 [block! string! binary! bitset! date! typeset! map!] "Second data set"
456+
set1 [block! string! bitset! date! typeset! map!] "First data set"
457+
set2 [block! string! bitset! date! typeset! map!] "Second data set"
458458
/case {Uses case-sensitive comparison}
459459
/skip {Treat the series as records of fixed size}
460460
size [integer!]
461461
]
462462

463463
exclude: native [
464464
{Returns the first data set less the second data set.}
465-
set1 [block! string! binary! bitset! typeset! map!] "First data set"
466-
set2 [block! string! binary! bitset! typeset! map!] "Second data set"
465+
set1 [block! string! bitset! typeset! map!] "First data set"
466+
set2 [block! string! bitset! typeset! map!] "Second data set"
467467
/case {Uses case-sensitive comparison}
468468
/skip {Treat the series as records of fixed size}
469469
size [integer!]
470470
]
471471

472472
intersect: native [
473473
{Returns the intersection of two data sets.}
474-
set1 [block! string! binary! bitset! typeset! map!] "first set"
475-
set2 [block! string! binary! bitset! typeset! map!] "second set"
474+
set1 [block! string! bitset! typeset! map!] "first set"
475+
set2 [block! string! bitset! typeset! map!] "second set"
476476
/case {Uses case-sensitive comparison}
477477
/skip {Treat the series as records of fixed size}
478478
size [integer!]
479479
]
480480

481481
union: native [
482482
{Returns the union of two data sets.}
483-
set1 [block! string! binary! bitset! typeset! map!] "first set"
484-
set2 [block! string! binary! bitset! typeset! map!] "second set"
483+
set1 [block! string! bitset! typeset! map!] "first set"
484+
set2 [block! string! bitset! typeset! map!] "second set"
485485
/case {Use case-sensitive comparison}
486486
/skip {Treat the series as records of fixed size}
487487
size [integer!]
488488
]
489489

490490
unique: native [
491491
{Returns the data set with duplicates removed.}
492-
set1 [block! string! binary! bitset! typeset! map!]
492+
set1 [block! string! bitset! typeset! map!]
493493
/case {Use case-sensitive comparison (except bitsets)}
494494
/skip {Treat the series as records of fixed size}
495495
size [integer!]

src/core/n-sets.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,11 @@ enum {
133133
RESET_TAIL(retser); // required - allow reuse
134134
break;
135135

136-
case REB_BINARY:
137-
cased = TRUE;
138-
SET_TYPE(D_RET, REB_BINARY);
136+
//case REB_BINARY:
137+
//!! Binary input is broken, so better to turn it of for now! !!//
138+
//!! https://github.com/Oldes/Rebol-issues/issues/1978 !!//
139+
// cased = TRUE;
140+
// SET_TYPE(D_RET, REB_BINARY);
139141
case REB_STRING:
140142
i = VAL_LEN(val1);
141143
// Setup result block:

0 commit comments

Comments
 (0)