Skip to content

Commit 1a05697

Browse files
committed
FIX: added initialization of local pointers to prevent Visual Studio errors C4703: potentially uninitialized local pointer variable
1 parent ff41a13 commit 1a05697

16 files changed

+20
-20
lines changed

src/core/c-error.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ static REBOL_STATE Top_State; // Boot var: holds error state during boot
737737
***********************************************************************/
738738
{
739739
REBVAL *policy = Get_System(SYS_STATE, STATE_POLICIES);
740-
REBYTE *flags;
740+
REBYTE *flags = NULL;
741741
REBCNT len;
742742
REBCNT errcode = RE_SECURITY_ERROR;
743743

src/core/f-dtoa.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -2504,7 +2504,7 @@ strtod
25042504
U aadj2, adj, rv, rv0;
25052505
ULong y, z;
25062506
BCinfo bc;
2507-
Bigint *bb, *bb1, *bd, *bd0, *bs, *delta;
2507+
Bigint *bb = 0, *bb1, *bd = 0, *bd0, *bs = 0, *delta = 0;
25082508
#ifdef Avoid_Underflow
25092509
ULong Lsb, Lsb1;
25102510
#endif
@@ -3711,7 +3711,7 @@ dtoa
37113711
int denorm;
37123712
ULong x;
37133713
#endif
3714-
Bigint *b, *b1, *delta, *mlo, *mhi, *S;
3714+
Bigint *b, *b1, *delta, *mlo = 0, *mhi, *S;
37153715
U d2, eps, u;
37163716
double ds;
37173717
char *s, *s0;

src/core/f-stubs.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@
731731
**
732732
***********************************************************************/
733733
{
734-
REBVAL *val;
734+
REBVAL *val = NULL;
735735
REBINT len;
736736
REBINT maxlen;
737737

src/core/n-data.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ static int Check_Char_Range(REBVAL *val, REBINT limit)
183183
}
184184
else {
185185
// /types [var1 integer! var2 [integer! decimal!]]
186-
REBVAL *val;
186+
REBVAL *val = NULL;
187187
REBVAL *type;
188188

189189
for (value = VAL_BLK_DATA(value); NOT_END(value); value += 2) {

src/core/n-loop.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@
261261
REBSER *frame;
262262
REBVAL *value;
263263
REBSER *series;
264-
REBSER *out; // output block (for MAP, mode = 2)
264+
REBSER *out = NULL; // output block (for MAP, mode = 2)
265265

266266
REBINT index; // !!!! should these be REBCNT?
267267
REBINT tail;

src/core/n-strings.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ static struct digest {
372372
***********************************************************************/
373373
{
374374
REBINT base = 64;
375-
REBSER *ser;
375+
REBSER *ser = NULL;
376376
REBCNT index;
377377
REBVAL *arg = D_ARG(1);
378378

src/core/s-file.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
REBCNT i = 0;
130130
REBCNT n = 0;
131131
REBUNI *out;
132-
REBCHR *lpath;
132+
REBCHR *lpath = NULL;
133133
REBCNT l = 0;
134134

135135
if (len == 0)

src/core/s-mold.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,8 @@ STOID Mold_String_Series(REBVAL *value, REB_MOLD *mold)
371371
REBSER *ser = VAL_SERIES(value);
372372
REBCNT idx = VAL_INDEX(value);
373373
REB_STRF sf = {0};
374-
REBYTE *bp;
375-
REBUNI *up;
374+
REBYTE *bp = NULL;
375+
REBUNI *up = NULL;
376376
REBUNI *dp;
377377
REBOOL uni = !BYTE_SIZE(ser);
378378
REBCNT n;
@@ -639,7 +639,7 @@ STOID Mold_Block_Series(REB_MOLD *mold, REBSER *series, REBCNT index, REBYTE *se
639639

640640
STOID Mold_Block(REBVAL *value, REB_MOLD *mold)
641641
{
642-
REBYTE *sep;
642+
REBYTE *sep = NULL;
643643
REBOOL all = GET_MOPT(mold, MOPT_MOLD_ALL);
644644
REBSER *series = mold->series;
645645
REBFLG over = FALSE;

src/core/s-trim.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ static REBFLG find_in_uni(REBUNI *up, REBINT len, REBUNI c)
5050
REBCNT wlen;
5151
REBUNI with_chars[MAX_WITH]; // chars to be trimmed
5252
REBUNI *up = with_chars;
53-
REBYTE *bp;
53+
REBYTE *bp = NULL;
5454
REBCNT n;
5555
REBUNI uc;
5656

src/core/t-date.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@
692692
REBDAT date;
693693
REBINT day, month, year;
694694
REBVAL *val;
695-
REBVAL *arg;
695+
REBVAL *arg = NULL;
696696
REBINT num;
697697

698698
val = D_ARG(1);

src/core/t-image.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ INLINE REBCNT ARGB_To_BGR(REBCNT i)
703703
REBCNT tail = VAL_TAIL(value);
704704
REBCNT len;
705705
REBCNT *ip = (REBCNT *)VAL_IMAGE_DATA(value); // NOTE ints not bytes
706-
REBCNT *p;
706+
REBCNT *p = NULL;
707707
REBINT n;
708708
REBOOL only = FALSE;
709709
REBYTE no_refs[10] = {5, 6, 7, 8, 9, 10, 13, 14}; // ref - 1 (invalid refinements)

src/core/t-object.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ static REBSER *Trim_Object(REBSER *obj)
279279
REBVAL *arg = D_ARG(2);
280280
REBINT n;
281281
REBVAL *val;
282-
REBSER *obj, *src_obj;
282+
REBSER *obj = NULL, *src_obj;
283283
REBCNT type = 0;
284284

285285
switch (action) {

src/core/t-pair.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
***********************************************************************/
178178
{
179179
REBVAL *val;
180-
REBVAL *arg;
180+
REBVAL *arg = NULL;
181181
REBINT n;
182182
REBD32 x1, x2;
183183
REBD32 y1, y2;

src/core/t-time.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@
364364
{
365365
REBI64 secs;
366366
REBVAL *val;
367-
REBVAL *arg;
367+
REBVAL *arg = NULL;
368368
REBI64 num;
369369

370370
val = D_ARG(1);

src/core/t-tuple.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@
186186
{
187187
REBVAL *value;
188188
REBVAL *arg;
189-
REBYTE *vp;
190-
REBYTE *ap;
189+
REBYTE *vp = NULL;
190+
REBYTE *ap = NULL;
191191
REBINT len;
192192
REBINT alen;
193193
REBINT v;

src/core/t-vector.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ void Set_Vector_Row(REBSER *ser, REBVAL *blk)
203203
REBCNT type = VECT_TYPE(VAL_SERIES(vect));
204204
REBSER *ser = Make_Block(len);
205205
REBCNT n;
206-
REBVAL *val;
206+
REBVAL *val = NULL;
207207

208208
if (len > 0) {
209209
val = BLK_HEAD(ser);

0 commit comments

Comments
 (0)