Skip to content

[Common, Proxy] - Bug proxy basic is not being returned from server factory #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaSBrown opened this issue Feb 1, 2025 · 0 comments · May be fixed by #1278
Open

[Common, Proxy] - Bug proxy basic is not being returned from server factory #1277

JoshuaSBrown opened this issue Feb 1, 2025 · 0 comments · May be fixed by #1278
Labels
Type: Bug Something isn't working

Comments

@JoshuaSBrown
Copy link
Collaborator

Description

There is a bug in the server factory, proxybasic is not returned anywhere. Proxy object is being created instead.

 } else if (server_type == ServerType::PROXY_BASIC_ZMQ) {
      if (incoming_operators.size() > 0) {
        EXCEPT_PARAM(1, "Error building PROXY_BASIC_ZMQ server, operators have "
                        "been provided that will never be used!");
      }
      return std::unique_ptr<IServer>(
          new Proxy(socket_options, socket_credentials, m_log_context));
    }

Acceptance

Change Proxy to ProxyBasic. in ServerFactory.

@JoshuaSBrown JoshuaSBrown added the Type: Bug Something isn't working label Feb 1, 2025
@JoshuaSBrown JoshuaSBrown linked a pull request Feb 1, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant