Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase banner: Review most semantically appropriate and accessible tag for badge #2462

Closed
jrbarnes9 opened this issue Sep 28, 2022 · 4 comments · Fixed by #2779
Closed

Phase banner: Review most semantically appropriate and accessible tag for badge #2462

jrbarnes9 opened this issue Sep 28, 2022 · 4 comments · Fixed by #2779
Assignees
Labels
Accessibility Issues discovered through accessibility testing

Comments

@jrbarnes9
Copy link
Contributor

  Looking at the HTML for this component, the BETA itself is wrapped in a H3 tag. Given its position on the page, this means (from what I could make out on Voiceover) that it appears as the first heading. Would this potentially be confusing for users flicking through the headers to just hear 'Beta' and nothing else? 

Within the GOV.UK Design System, they seem to use a strong tag instead. Consequently it's not read out when navigating through the various headers on the page.

Originally posted by @LaurenDowling in #8 (comment)

@jrbarnes9 jrbarnes9 added the Accessibility Issues discovered through accessibility testing label Sep 28, 2022
@boxadesign boxadesign self-assigned this Oct 3, 2022
@boxadesign
Copy link
Contributor

boxadesign commented Oct 4, 2022

Waiting for advice from DAC to see if we need to add aria attributes to the wrapping element

@yatesn
Copy link

yatesn commented Dec 16, 2022

Still waiting for response from DAC

@jrbarnes9
Copy link
Contributor Author

Response from DAC:

"I discussed this with my colleagues, and we concluded that adding an alert could be too intrusive. Since users move through a webpage linearly, they’ll see the banner on each new page. As you mentioned, the user may skip the phase banner. Although, this most likely happens if the user has seen the page before."

@emilymaylawes
Copy link

Based on the comment above, is it best to change this to a <strong> tag, considering users may skip over the phase banner after reading it once?
At the moment, having it as a <h3> does not make explicit sense as to why this level was selected, as it does not sit underneath any other content, and there is a question as to why it isn't even a <h2>. It is the only semantic heading inside the <header>> as well which grants it significant important as the first heading on the page.
My recommendation would be to make it a <strong> element as proposed, and as GDS do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants