Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase banner recommended content link text should be more descriptive out of context #1601

Closed
jrbarnes9 opened this issue Jul 23, 2021 · 0 comments · Fixed by #1985
Closed

Phase banner recommended content link text should be more descriptive out of context #1601

jrbarnes9 opened this issue Jul 23, 2021 · 0 comments · Fixed by #1985
Labels
Accessibility Issues discovered through accessibility testing Enhancement Change of existing feature

Comments

@jrbarnes9
Copy link
Contributor

jrbarnes9 commented Jul 23, 2021 •
edited
Loading

Phase banner recommended content link text should be more descriptive out of context and at the end of the sentence. e.g. "This is a new service. To help us improve it, please give us your feedback"

Fails WCAG 2.4.4 Link Purpose (In Context)

Originally posted by @jrbarnes9 in #8 (comment)
@jrbarnes9 jrbarnes9 changed the title Phase banner recommended content link text should be more descriptive out of context and at the end of the sentence. e.g. "This is a new service. To help us improve it, please [give us your feedback](/#0)" Phase banner recommended content link text should be more descriptive out of context Jul 23, 2021
@jrbarnes9 jrbarnes9 added Accessibility Issues discovered through accessibility testing Enhancement Change of existing feature labels Jul 23, 2021
@jrbarnes9 jrbarnes9 mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Issues discovered through accessibility testing Enhancement Change of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve phase banner content ONSdigital/design-system
1 participant
@jrbarnes9