Integer overflow 4527 v5 #6778
Closed
Integer overflow 4527 v5 #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly truncate a file name if it is longer than UINT16_MAX
Explicitly truncate file names to UINT16_MAX Before, they got implicitly truncated, meaning a UINT16_MAX + 1 file name, went to 0 file name (because of modulo 65536)
and explicitly truncating filename's length
especially increasing padding_len size
to be used for maximum size of file names, and not depend on the OS
Codecov Report
@@ Coverage Diff @@
## master #6778 +/- ##
==========================================
- Coverage 77.12% 74.52% -2.61%
==========================================
Files 615 615
Lines 185613 185621 +8
==========================================
- Hits 143161 138328 -4833
- Misses 42452 47293 +4841
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
|
Merged in #6779, thanks! |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Feb 13, 2024
Direction flag was checked against wrong field, leading to undefined behavior. Bug: OISF#6778.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Feb 14, 2024
Direction flag was checked against wrong field, leading to undefined behavior. Bug: OISF#6778.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4527
Describe changes:
libhtp-pr: 339
There remains one warning about the use of
StreamTcpUpdateAppLayerProgresscf discussion in #6649
Changes #6690 with needed rebase and fixed conflicts