rust: don't suppress static_mut_refs globally - v3 #12680
Closed
+54
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't appear to be needed. The vec being cleared is only set once per run, so never needs to be cleared. Removes one point where we have to supress the static_mut_refs compiler warning. Ticket: OISF#7417
Allows us to get rid of the global supression. Ticket: OISF#7417
Simply wrapping in a function removes static_mut_refs compiler warning. Ticket: OISF#7417
As references to static mutables are highly discouraged, remove the global suppressing of the compiler warning. Each use case can be suppressed as needed. Ticket: OISF#7417
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12680 +/- ##
=======================================
Coverage 80.75% 80.76%
=======================================
Files 934 934
Lines 259594 259604 +10
=======================================
+ Hits 209634 209664 +30
+ Misses 49960 49940 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Feb 26, 2025
|
Information: QA ran without warnings. Pipeline 24921 |
Merged
catenacyber
reviewed
Feb 27, 2025
| @@ -383,7 +382,6 @@ static void SMTPConfigure(void) { | |||
| } else { | |||
| /* Add default extract url scheme 'http' since | |||
| * extract-urls-schemes wasn't found in the config */ | |||
| SCMimeSmtpConfigExtractUrlsSchemeReset(); | |||
There was a problem hiding this comment.
Thanks I think I used this while trying to have a fuzz target that reload the configuration for each input
|
Merged in #12685, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As its use is now a default compiler warning, and eventually will become an
error, remove the global suppression of it. Instead suppress as needed, or
refactor to get rid of the warning.
For reference:
https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html,
Ticket: https://redmine.openinfosecfoundation.org/issues/7417