tests: flowbit prefilter tests #2317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
catenacyber
reviewed
Feb 25, 2025
| @@ -0,0 +1,10 @@ | |||
| alert tcp any any -> any any (flow:to_client; content:"HTTP"; flowbits:set,rare; flowbits:set,common; sid:11;) | |||
There was a problem hiding this comment.
What is the rare flowbit about ?
catenacyber
reviewed
Feb 25, 2025
| match: | ||
| event_type: alert | ||
| pcap_cnt: 6 | ||
| alert.signature_id: 25 |
There was a problem hiding this comment.
Do not we get this on test 1 as well ?
catenacyber
reviewed
Feb 25, 2025
| match: | ||
| event_type: alert | ||
| pcap_cnt: 6 | ||
| alert.signature_id: 33 |
There was a problem hiding this comment.
Should not we have engine-analysis tests as well ?
victorjulien
force-pushed
the
flowbits-prefilter/v7
branch
from
6d25c67 to
f15e20f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase of #2231