Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opae: fix user clock configuration sequence numbers #3156

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

michael-adler
Copy link
Member

The CSR interface for changing the user clock frequency relies on sequence numbers to detect the next command. In normal operation, a command stream ends by forcing the hardware sequence counter to zero. If the command stream is interrupted, the sequence number may be left non-zero. Update the command stream to start counting from the current sequence number in hardware.

Tests run:

Forced non-zero starting seq on HW, confirmed that commands were detected with Signal Tap.

The CSR interface for changing the user clock frequency relies on
sequence numbers to detect the next command. In normal operation,
a command stream ends by forcing the hardware sequence counter to
zero. If the command stream is interrupted, the sequence number may
be left non-zero. Update the command stream to start counting from
the current sequence number in hardware.

Signed-off-by: Michael Adler <michael.adler@altera.com>
@michael-adler michael-adler self-assigned this Jan 29, 2025
@michael-adler michael-adler requested a review from a team as a code owner January 29, 2025 22:12
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @michael-adler!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13041424558

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.101%

Totals Coverage Status
Change from base Build 12939628528: 0.0%
Covered Lines: 15826
Relevant Lines: 24689

💛 - Coveralls

@michael-adler michael-adler merged commit 893d2db into OFS:master Jan 29, 2025
21 checks passed
@michael-adler michael-adler deleted the mcadler/uclk branch January 29, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants