Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pci_device: improved reset sequence #3144

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

michael-adler
Copy link
Member

  • Wait for data link active after triggering a bridge's secondary device reset.
  • Move reset to a separate command that unloads drivers, then devices, triggers warm reset on FPGAs, and finally rescans and clears errors.

Fixes: c97c3f2 ("pci_device: Add bridge reset when a device is unplugged (#3143)")

Tests run:

Tested designs with and without VFs, confirmed that warm reset is raised using SignalTap.

- Wait for data link active after triggering a bridge's secondary device reset.
- Move reset to a separate command that unloads drivers, then devices, triggers
  warm reset on FPGAs, and finally rescans and clears errors.

Fixes: c97c3f2 ("pci_device: Add bridge reset when a device is unplugged (OFS#3143)")

Signed-off-by: Michael Adler <michael.adler@intel.com>
@michael-adler michael-adler requested a review from a team as a code owner December 19, 2024 20:04
@michael-adler michael-adler self-assigned this Dec 19, 2024
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michael-adler, looks good.

@michael-adler michael-adler merged commit fef8448 into OFS:master Dec 19, 2024
17 checks passed
@michael-adler michael-adler deleted the mcadler/pci_reset branch December 19, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants