Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No release includes the fixes to the cross-references #4135

Closed
MikeSpreitzer opened this issue Oct 14, 2024 · 6 comments
Closed

No release includes the fixes to the cross-references #4135

MikeSpreitzer opened this issue Oct 14, 2024 · 6 comments
Labels
Housekeeping Needs author feedback No recent activity The issue has not been updated in 7 days.

Comments

@MikeSpreitzer
Copy link

Recall that #3548 tracked a change in how GitHub renders markdown to HTML, 8 months ago. There is not yet any tagged commit in this repo that includes this fix.

@handrews
Copy link
Member

@MikeSpreitzer that's because they're not re-releases and you can't really change tags in git (not without causing tons of problems). For the versions directory, the markdown on the main branch is what's rendered as HTML on spec.openapis.org (for the schemas directory its more complicated and currently under review).

We made the changes in-place for convenience of people browsing in GitHub, because broken links are bad. But it's not a change in the spec itself.

@handrews
Copy link
Member

@MikeSpreitzer if that doesn't make sense, it would help to know what you're trying to do with the tags. When we made that change, we couldn't really figure out how the tags were used (no one involved in deciding to make them was available and remembered).

@github-actions github-actions bot added the No recent activity The issue has not been updated in 7 days. label Oct 22, 2024
Copy link
Contributor

This issue has been labeled with No recent activity because there has been no recent activity. It will be closed if no further activity occurs within 28 days. Please re-open this issue or open a new one after this delay if you need to.

@lornajane
Copy link
Contributor

We've recently released new versions, @MikeSpreitzer, could you confirm if https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.1.md has the fixes you were hoping for?

@lornajane lornajane removed the No recent activity The issue has not been updated in 7 days. label Nov 4, 2024
@github-actions github-actions bot added the No recent activity The issue has not been updated in 7 days. label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This issue has been labeled with No recent activity because there has been no recent activity. It will be closed if no further activity occurs within 28 days. Please re-open this issue or open a new one after this delay if you need to.

@MikeSpreitzer
Copy link
Author

I was not asking for a change in a tag, I was asking for a new tag. 3.1.1 fits the bill. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Needs author feedback No recent activity The issue has not been updated in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants