Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team-list: establish categorization team #362938

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Dec 7, 2024

Important

If you want to be on the team initially, please comment by 2024-12-15 (we will remove non-responsive initial team members after this deadline). We can add interested people to the team later, if they are still interested.

Per RFC 0146:
https://github.com/NixOS/rfcs/blob/master/rfcs/0146-meta-categories.md#categorization-team

"a team entrusted with authority to manage issues related to categorization and carry their corresponding duties"

I added people to the team who were pinged in the below tracking issue, sorted alphabetically; the list of members is not set in stone.

Tracking: #360727

I requested reviews from the shepherd team for the RFC, as well as the creator of the above tracking issue.

I think it's reasonable to make shepherd reviews (at least from Raskin, the lead) blocking. Other reviews are, of course, appreciated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch from 32b390d to c13c09b Compare December 7, 2024 21:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 7, 2024
@SigmaSquadron

This comment was marked as resolved.

@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch from c13c09b to a1c70d3 Compare December 7, 2024 21:49
@tomodachi94
Copy link
Member Author

Added :)

@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch from a1c70d3 to 77aadf3 Compare December 7, 2024 21:57
@tomodachi94
Copy link
Member Author

tomodachi94 commented Dec 7, 2024

Created a GitHub team and linked it to the team created by this PR.

Update: winterqt has added it to the repository with the triage permission.

@tomodachi94 tomodachi94 changed the title team-list: establish categorization team [RFC 0146] team-list: establish categorization team Dec 7, 2024
@tomodachi94 tomodachi94 changed the title [RFC 0146] team-list: establish categorization team team-list: establish categorization team Dec 7, 2024
@tomodachi94 tomodachi94 added the 5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue label Dec 7, 2024
@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch 2 times, most recently from 59c085b to c107d7c Compare December 7, 2024 22:20
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see what comes out of this :)

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 7, 2024
@Aleksanaa Aleksanaa removed the request for review from SigmaSquadron December 8, 2024 03:47
@SigmaSquadron SigmaSquadron added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 8, 2024
@7c6f434c
Copy link
Member

7c6f434c commented Dec 8, 2024

Seems fine to me — but is everyone in the proposed team review-requested (or has already reacted here)? It looks like not enough review requests.

@tomodachi94 tomodachi94 requested a review from Lyndeno December 8, 2024 20:30
@tomodachi94
Copy link
Member Author

Seems fine to me — but is everyone in the proposed team review-requested (or has already reacted here)? It looks like not enough review requests.

I requested most of the reviews but missed one. If I recall correctly, the people added here have already expressed interest in joining the team, but let's wait for approvals from everyone before we merge this.

@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch from c107d7c to 30fa116 Compare December 8, 2024 20:37
@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Dec 8, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tomodachi94
Copy link
Member Author

tomodachi94 commented Dec 9, 2024

Would it be reasonable to remove anyone who doesn't respond by the start of next week (2024-12-15)? I think we're supposed to have the approvals of everyone listed on this team, but I'm not confident we'll get a response from everyone.

We can always add people to the team after this PR.

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Dec 9, 2024
@Lyndeno
Copy link
Contributor

Lyndeno commented Dec 9, 2024

I look forward to seeing what we can accomplish here

@tomodachi94
Copy link
Member Author

Currently just waiting on a response from @fgaz.

@philiptaron
Copy link
Contributor

I'll be on the team, if you'll have me. Information architecture is quite important.

Per RFC 146:
https://github.com/NixOS/rfcs/blob/master/rfcs/0146-meta-categories.md#categorization-team

> "a team entrusted with authority to manage issues related to categorization and carry their corresponding duties"
@tomodachi94 tomodachi94 force-pushed the create/team-list/categorization branch from 30fa116 to af682f3 Compare December 10, 2024 02:52
@Aleksanaa
Copy link
Member

Merging this as we have gathered all approvals 🚀

@Aleksanaa Aleksanaa merged commit 4d419ea into NixOS:master Dec 11, 2024
32 checks passed
@SigmaSquadron SigmaSquadron removed the request for review from getchoo December 11, 2024 02:48
@tomodachi94 tomodachi94 deleted the create/team-list/categorization branch December 11, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5. scope: tracked Issue (or PR) is linked back to a `5. scope: tracking` issue 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.