podman-desktop: 1.13.2 -> 1.15.0 #361460
podman-desktop: 1.13.2 -> 1.15.0 #361460
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
|
kachick
force-pushed
the
update-podman-desktop
branch
2 times, most recently
from
bd6e798 to
c688e2d
Compare
|
Thank you for the PR; thanks for including helpful details about particular changes in the commit message. The code change look good, and I was able to build both for linux and darwin. The darwin version starts and seems to work fine. My only concern is that the commit message lines are not as wrapped as it could be (I don't see a lot of commits in the repo that have such long lines). But I'm new to nixpkgs maintenance, maybe it's acceptable here. Let me know what you think. Other than that, this is good to go. |
Diff: podman-desktop/podman-desktop@v1.13.2...v1.14.1 Update postPatch with podman-desktop/podman-desktop@8af3761 This fixes nixpkgs-update failure https://nixpkgs-update-logs.nix-community.org/podman-desktop/2024-11-26.log ``` patching file extensions/podman/packages/extension/package.json substituteStream() in derivation podman-desktop-1.14.1: ERROR: pattern process.resourcesPath doesn't match anything in file 'packages/main/src/tray-animate-icon.ts' ``` Pin pnpm and electron version to respect https://github.com/NixOS/nixpkgs/blob/1c26355e02ea8aa9bef6a7b3f59d74bd3c504c11/doc/languages-frameworks/javascript.section.md?plain=1#L427 Checked the version in https://github.com/podman-desktop/podman-desktop/blob/v1.14.1/package.json https://github.com/podman-desktop/podman-desktop/blob/v1.14.1/pnpm-lock.yaml Attempt to fix the Linux build with inherit finalAttrs.patches ``` error: hash mismatch in fixed-output derivation '/nix/store/xq1bg197mw0a0gr1k06xfr405d03fsg3-podman-desktop-pnpm-deps.drv': specified: sha256-f7LDfKMPaVRtgvZLFz2JePXd45JBdBCNQR/Ch6VaBKU= got: sha256-bbfyEpDj85HGC3fNLY2to2nKdldbefklJjWGpAYdSdw= ``` See https://github.com/NixOS/nixpkgs/blob/1c26355e02ea8aa9bef6a7b3f59d74bd3c504c11/doc/languages-frameworks/javascript.section.md?plain=1#L429 However it still making hash mismatch in nixpkgs-review
kachick
force-pushed
the
update-podman-desktop
branch
from
c688e2d to
ee6b165
Compare
kachick
changed the title
| hash = "sha256-LPsNRd1c/cQeyBn3LZKnKeAsZ981sOkLYTnXIZL82LA="; | ||
| pnpmDeps = pnpm_9.fetchDeps { | ||
| inherit (finalAttrs) pname version src patches; | ||
| hash = "sha256-EzkAcd84JEBq6eDkh9XCGfCyeo5r2vpZSIvb2hqpsBU="; |
There was a problem hiding this comment.
This hash always will be different in nixpkgs-review in x86_64-linux report.
In nixpkgs-review
error: hash mismatch in fixed-output derivation '/nix/store/hm84x737h5dnd3g2ky8k5hg6fkmd8ly6-podman-desktop-pnpm-deps.drv':
specified: sha256-EzkAcd84JEBq6eDkh9XCGfCyeo5r2vpZSIvb2hqpsBU=
got: sha256-2wmMuymv8C1ZVeGnWf2R3t9cf1jqiFIw0KJ/m3/cxZs=
error: 1 dependencies of derivation '/nix/store/wgrqfbf8wqkhvk7br091vw2nkfpn94dg-podman-desktop-1.15.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fiw3n0zkxpwv2zcsc6zc0rya43rs315l-review-shell.drv' failed to build
It succeeds in darwin. I have no idea what is this 🤔
There was a problem hiding this comment.
Might be related to #350063?
|
@booxter Thank you for your reviewing. 🙏 I don't have confidence that wrapping long URLs and logs will be better or not in the commit message. So keeping now. But I can modify commit messages if required. Any suggestions welcome. However running nixpkgs-review always fails for the x86_64-linux and |
I can not reproduce in my device, however github hosted ubuntu-24.04 runner always returns different hash for fetchDeps
|
I have no idea how to fix the hash mismatch, at least this year. Sorry for closing this PR 🙇. |
Diff: podman-desktop/podman-desktop@v1.13.2...v1.15.0
Update postPatch with podman-desktop/podman-desktop@8af3761
This PR aims to fix failure in nixpkgs-update
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.