Support setting devicetree for systemd-boot via bootspec #330195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
I think it makes sense to have this as a bootspec extension, it is planned to have it in bootspec V2 anyway. Will do a more complete review asap. |
|
Related to #319422 |
Oops. Didn't notice someone already did basically the same thing. |
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
|
#319422 has been merged, closing. Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds support for setting the devicetree when using systemd-boot as bootloader via a bootspec extension.
I'm currently running this successfully on a Raspberry Pi 4B.
Note that I've added the devicetree setting to bootspec as an extension, it might make more sense to add it natively, I'm not sure.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.