Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#209870 broke llvmPackages_rocm.clang #225780

Closed
ghost opened this issue Apr 11, 2023 · 9 comments
Closed

#209870 broke llvmPackages_rocm.clang #225780

ghost opened this issue Apr 11, 2023 · 9 comments

Comments

@ghost
Copy link

ghost commented Apr 11, 2023 •
edited by ghost
Loading

Also same-looking issue in llvmPackages_rocm but not in other llvmPackages versions that we build. (I just confirmed that the PR doesn't fix it and reverting glibc upgrade doesn't fix it. It sounds possible that this PR triggered them.) Build links:

https://hydra.nixos.org/build/214886749
https://hydra.nixos.org/build/215014044

Originally posted by @vcunat in #209870 (comment)
@ghost ghost mentioned this issue Apr 11, 2023
Merged
4 tasks
@ghost
Copy link
Author

ghost commented Apr 11, 2023

#209870 (comment)

@ghost
Copy link
Author

ghost commented Apr 11, 2023

#209870 (comment)

@ghost
Copy link
Author

ghost commented Apr 11, 2023

#209870 (comment)

@ghost
Copy link
Author

ghost commented Apr 11, 2023

#209870 (comment)

@ghost
Copy link
Author

ghost commented Apr 11, 2023

I just succeeded with llvmPackages_rocm.clang this way, as an experiment in vcunat@14fd6d2aaaec82.

If you can hold off a bit before merging that I'm trying the same NIX_CFLAGS_COMPILE="-v"-and-diff trick I used in #225220 to try to find the minimal change that fixes it, instead of a wholesale revert. But it will be an hour or two before the builds complete.

@ghost ghost changed the title Also same-looking issue in llvmPackages_rocm but not in other llvmPackages versions that we build. (I just confirmed that the PR doesn't fix it and reverting glibc upgrade doesn't fix it. It sounds possible that this PR triggered them.) Build links: #209870 broke llvmPackages_rocm.clang Apr 11, 2023
@ghost ghost self-assigned this Apr 11, 2023
@ghost

This comment was marked as outdated.

Sign in to view
@ghost

This comment was marked as outdated.

Sign in to view
@ghost
Copy link
Author

ghost commented Apr 12, 2023

There is a pretty good chance that #225846 will fix this too. I'm running a build to find out, but I won't be awake when it finishes.

@ghost
Copy link
Author

ghost commented Apr 12, 2023

Fixed by #225846

@ghost ghost closed this as completed Apr 12, 2023
@ghost ghost mentioned this issue Apr 12, 2023
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants