-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable channel shows wrong version in the suggestions view #307
Comments
To fix this, we probably need to monitor the date of the last ingestion, now that we have nuked the database, we cannot observe this on the long term anymore. |
Ah, are you saying this is merely evaluations being out of sync, e.g. that we see old things on unstable because the last eval of unstable was before evaling stable branches? In any case, keeping the evaluation timestamp would be nice, because we can display possible discrepancies right there in the UI. And maybe also show the commit hash we're working with for a given branch. |
Correct. |
We're not updating existing suggestions with new evaluations, right? This seems to be related to #201 We may want to update all derivations on existing suggestions with new evaluation data, and highlight if there was a change since the last manual modification. E.g., for "selected" suggestions: if the last change from the activity log was before the bump, make it visible that versions may have changed. Ideally we'd only highlight when they actually changed. |
This is true, this means that once channel are updated, we need to:
warning : this means we need to develop a way to relate derivation in channel rev X and derivation in channel rev Y. |
Now with #378, the extra surprise is whenever we update suggestions, we need to schedule a background job to recache it. |
I have no idea yet how it works or wether it's an actual issue, but there seems to be the pattern, that the old stable version and the unstable version seem to be equal, while the new stable version is newer. Hints towards a bug.
Edit by @fricklerhandwerk:
We want to display when the evaluation for a matched derivation was made, so users can inspect whether the data is recent. Needs refinement on how to present that.
The text was updated successfully, but these errors were encountered: