Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable channel shows wrong version in the suggestions view #307

Open
erictapen opened this issue Oct 31, 2024 · 6 comments · May be fixed by #461
Open

Unstable channel shows wrong version in the suggestions view #307

erictapen opened this issue Oct 31, 2024 · 6 comments · May be fixed by #461
Assignees
Labels
bug Something isn't working data something about quality or quantity of ingested data

Comments

@erictapen
Copy link
Contributor

erictapen commented Oct 31, 2024

I have no idea yet how it works or wether it's an actual issue, but there seems to be the pattern, that the old stable version and the unstable version seem to be equal, while the new stable version is newer. Hints towards a bug.

tmp J9lSQSs1Lo

Edit by @fricklerhandwerk:

We want to display when the evaluation for a matched derivation was made, so users can inspect whether the data is recent. Needs refinement on how to present that.

@erictapen erictapen added the bug Something isn't working label Oct 31, 2024
@erictapen erictapen self-assigned this Oct 31, 2024
@fricklerhandwerk fricklerhandwerk added the data something about quality or quantity of ingested data label Oct 31, 2024
@fricklerhandwerk fricklerhandwerk changed the title Package versions in the suggestions view seem to repeat themselfes Unstable channel shows wrong version in the suggestions view Nov 11, 2024
@RaitoBezarius
Copy link
Collaborator

To fix this, we probably need to monitor the date of the last ingestion, now that we have nuked the database, we cannot observe this on the long term anymore.

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Nov 14, 2024

Ah, are you saying this is merely evaluations being out of sync, e.g. that we see old things on unstable because the last eval of unstable was before evaling stable branches?

In any case, keeping the evaluation timestamp would be nice, because we can display possible discrepancies right there in the UI. And maybe also show the commit hash we're working with for a given branch.

@RaitoBezarius
Copy link
Collaborator

Correct.

@fricklerhandwerk
Copy link
Collaborator

We're not updating existing suggestions with new evaluations, right? This seems to be related to #201

We may want to update all derivations on existing suggestions with new evaluation data, and highlight if there was a change since the last manual modification. E.g., for "selected" suggestions: if the last change from the activity log was before the bump, make it visible that versions may have changed. Ideally we'd only highlight when they actually changed.

@RaitoBezarius
Copy link
Collaborator

This is true, this means that once channel are updated, we need to:

  • expire all pending suggestions and redo them
  • iterate over rejected suggestions and accepted suggestions
    • do as if we were going to rematch things up
    • compare what is newly matched with what exist already
    • "replace" the M2M row for everything we can link (old derivation, new derivation)
    • add the new M2M rows
    • delete the old M2M we cannot match up

warning : this means we need to develop a way to relate derivation in channel rev X and derivation in channel rev Y.
(this problem also exist in some of the optimization work we do in Lix/Hydra for build analytics, I think what we can do is to track by attrPath and that's… probably the best we can do? i.e. if someone moves the derivation to another attribute path, bye bye, we lost it.)

@RaitoBezarius
Copy link
Collaborator

Now with #378, the extra surprise is whenever we update suggestions, we need to schedule a background job to recache it.

@fricklerhandwerk fricklerhandwerk moved this from Needs refinement to Ready in Nixpkgs Vulnerability Tracker Nov 28, 2024
@RaitoBezarius RaitoBezarius moved this from Ready to Blocking in Nixpkgs Vulnerability Tracker Nov 29, 2024
@RaitoBezarius RaitoBezarius moved this from Blocking to Ready in Nixpkgs Vulnerability Tracker Nov 29, 2024
@fricklerhandwerk fricklerhandwerk moved this from Ready to In Progress in Nixpkgs Vulnerability Tracker Dec 5, 2024
@fricklerhandwerk fricklerhandwerk moved this from In Progress to Ready in Nixpkgs Vulnerability Tracker Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data something about quality or quantity of ingested data
Projects
Status: Ready
Development

Successfully merging a pull request may close this issue.

3 participants