Skip to content

Commit 5168369

Browse files
committed
docker: drop :jupyter tag
1 parent 16377f2 commit 5168369

8 files changed

+15
-15
lines changed

.github/workflows/docker.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
run: |
9191
# rebuild sirf image
9292
./docker/compose.sh -bR${{ matrix.type == 'gpu' && 'g' || 'c' }}
93-
image=synerbi/sirf:jupyter${{ steps.pull.outputs.suffix }}
93+
image=synerbi/sirf:latest${{ steps.pull.outputs.suffix }}
9494
echo "image=$image" >> "$GITHUB_OUTPUT"
9595
# tag potentially newer core image
9696
docker tag synerbi/jupyter:scipy-${{ matrix.type }} ${{ steps.pull.outputs.core_image }}
@@ -174,7 +174,7 @@ jobs:
174174
run: |
175175
# rebuild sirf image
176176
./docker/compose.sh -dbR${{ matrix.type == 'gpu' && 'g' || 'c' }}
177-
image=synerbi/sirf:jupyter-devel${{ steps.pull.outputs.suffix }}
177+
image=synerbi/sirf:devel${{ steps.pull.outputs.suffix }}
178178
echo "image=$image" >> "$GITHUB_OUTPUT"
179179
- name: test CIL
180180
run: >

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ services:
4141
BUILD_GPU: 0
4242
sirf:
4343
container_name: sirf # for scaling, comment this out https://github.com/docker/compose/issues/3729
44-
image: synerbi/sirf:jupyter
44+
image: synerbi/sirf:latest
4545
build:
4646
context: .
4747
args:

docker/README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ The image contains SIRF & all dependencies required by JupyterHub.
1111

1212
```sh
1313
# CPU version
14-
docker run --rm -it -p 9999:8888 ghcr.io/synerbi/sirf:jupyter
14+
docker run --rm -it -p 9999:8888 ghcr.io/synerbi/sirf:latest
1515
# GPU version
16-
docker run --rm -it -p 9999:8888 --gpus all ghcr.io/synerbi/sirf:jupyter-gpu
16+
docker run --rm -it -p 9999:8888 --gpus all ghcr.io/synerbi/sirf:latest-gpu
1717
```
1818

1919
> [!TIP]
2020
> docker tag | CIL branch/tag
2121
> :---|:---
22-
> `latest`, `latest-gpu`, `jupyter`, `jupyter-gpu` | [latest tag `v*.*.*`](https://github.com/SyneRBI/SIRF-SuperBuild/releases/latest)
22+
> `latest`, `latest-gpu` | [latest tag `v*.*.*`](https://github.com/SyneRBI/SIRF-SuperBuild/releases/latest)
2323
> `M`, `M.m`, `M.m.p`, `M-gpu`, `M.m-gpu`, `M.m.p-gpu` | tag `vM.m.p`
2424
> `edge`, `edge-gpu` | `master`
2525
> only build & test (no tag) | CI (current commit)
@@ -35,7 +35,7 @@ The Jupyter notebook should be accessible at <http://localhost:9999>.
3535
> ```sh
3636
> docker run --rm -it -p 9999:8888 --user $(id -u) --group-add users \
3737
> -v ./devel:/home/jovyan/work \
38-
> ghcr.io/synerbi/sirf:jupyter
38+
> ghcr.io/synerbi/sirf:latest
3939
> ```
4040
4141
More config: <https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#user-related-configurations>.
@@ -46,7 +46,7 @@ More config: <https://jupyter-docker-stacks.readthedocs.io/en/latest/using/commo
4646
> ```sh
4747
> docker run --rm -it -p 9999:8888 --user $(id -u) --group-add users \
4848
> -v /mnt/data:/share -e SIRF_DOWNLOAD_DATA_ARGS="-pm -D /share" \
49-
> ghcr.io/synerbi/sirf:jupyter
49+
> ghcr.io/synerbi/sirf:latest
5050
> ```
5151
5252
### Extending
@@ -55,9 +55,9 @@ You can build custom images on top of the SIRF ones, likely needing to switch be
5555
5656
```Dockerfile
5757
# CPU version
58-
# FROM synerbi/sirf:jupyter
58+
# FROM synerbi/sirf:latest
5959
# GPU version
60-
FROM synerbi/sirf:jupyter-gpu
60+
FROM synerbi/sirf:latest-gpu
6161
USER root
6262
RUN mamba install pytorch && fix-permissions "${CONDA_DIR}" /home/${NB_USER}
6363
USER ${NB_UID}

docker/compose.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set -euo pipefail
33

44
print_help(){
55
cat <<EOF
6-
Creates images: synerbi/sirf:jupyter, synerbi/sirf:jupyter-gpu
6+
Creates images: synerbi/sirf:latest, synerbi/sirf:latest-gpu
77
Also creates intermediate (temp) images: synerbi/jupyter
88
99
Usage: $0 [options] [-- [docker compose options]]

docker/devel/shared.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Host:
44

55
`SIRF-SuperBuild/docker/devel`
66

7-
Docker container (synerbi/sirf:jupyter):
7+
Docker container (synerbi/sirf:latest):
88

99
`/home/jovyan/work`
1010

docker/docker-compose.devel-gpu.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ services:
33
sirf-build:
44
image: synerbi/jupyter:sirf-build-devel-gpu
55
sirf:
6-
image: synerbi/sirf:jupyter-devel-gpu
6+
image: synerbi/sirf:devel-gpu
77
build:
88
cache_from: [synerbi/jupyter:sirf-build-devel-gpu]

docker/docker-compose.devel.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ services:
99
-DBUILD_CIL=ON
1010
sirf:
1111
container_name: sirf # for scaling, comment this out https://github.com/docker/compose/issues/3729
12-
image: synerbi/sirf:jupyter-devel
12+
image: synerbi/sirf:devel
1313
build:
1414
context: .
1515
args:

docker/docker-compose.gpu.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ services:
2929
Gadgetron_USE_CUDA: "ON"
3030
sirf:
3131
deploy: {resources: {reservations: {devices: [{driver: nvidia, count: all, capabilities: [gpu]}]}}}
32-
image: synerbi/sirf:jupyter-gpu
32+
image: synerbi/sirf:latest-gpu
3333
build:
3434
args:
3535
BASE_CONTAINER: synerbi/jupyter:scipy-gpu

0 commit comments

Comments
 (0)