Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update mutation logic #303

Merged
merged 5 commits into from
Feb 5, 2024
Merged

fix: update mutation logic #303

merged 5 commits into from
Feb 5, 2024

Conversation

cgilbe27
Copy link
Contributor

@cgilbe27 cgilbe27 commented Feb 5, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Updated the handling of marketing mutations to improve flexibility and testing.
  • Tests
    • Added tests for new marketing mutation functionality.
  • Chores
    • Enhanced utility functions to support generic types, improving code usability and type safety.

@cgilbe27 cgilbe27 self-assigned this Feb 5, 2024
@cgilbe27 cgilbe27 requested a review from CalicoNino February 5, 2024 20:44
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@cgilbe27 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 35 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 1779826 and e3fb815.

Walkthrough

The recent changes encompass a significant update to the GraphQL schema and related functionality, focusing on marketing mutations. These alterations include the introduction of new types and modifications to method signatures to enhance marketing capabilities, particularly around Twitter user data. The adjustments streamline the process for marketing mutations, reflecting a shift towards integrating Twitter user information more closely with marketing efforts.

Changes

Files Change Summary
.../heart-monitor.test.ts - Added imports for mutation types and a test for marketing mutations.
.../heart-monitor.ts - Updated marketingMutation method to accept GQLTwitterUser instead of GQLMarketingMutation.
.../mutation/marketing.ts - Replaced GQLMarketingMutation with GQLTwitterUser in imports and function signatures.
.../utils/consts.ts - Modified arg function to be generic and adjusted gqlQueryBatchHandler to use generics in calls.

🐇✨
Changes afoot in the code, so neat,
Marketing's dance with Twitter, oh so sweet.
Through the fields of data, we hop and leap,
For a future where connections run deep.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4f93be8 and 1779826.
Files ignored due to path filters (1)
  • package.json is excluded by: !**/*.json
Files selected for processing (4)
  • src/gql/heart-monitor/heart-monitor.test.ts (2 hunks)
  • src/gql/heart-monitor/heart-monitor.ts (3 hunks)
  • src/gql/mutation/marketing.ts (3 hunks)
  • src/gql/utils/consts.ts (2 hunks)
Additional comments: 10
src/gql/mutation/marketing.ts (3)
  • 8-8: The import of GQLTwitterUser replaces GQLMarketingMutation, aligning with the shift towards using Twitter user data in marketing mutations.
  • 22-22: The method signature of marketingMutationString now accepts fields?: Partial<GQLTwitterUser>, reflecting the updated data model focus.
  • 37-37: The method signature of marketingMutation has been updated similarly to accept fields?: Partial<GQLTwitterUser>, ensuring consistency with the data model change.
src/gql/utils/consts.ts (2)
  • 18-27: The arg function now accepts a generic type <T> and adjusts its return logic based on the type of value, enhancing type safety and flexibility.
  • 120-120: The gqlQuery function call within gqlQueryBatchHandler now includes the generic type <T> when calling the arg function, ensuring type consistency and safety.
src/gql/heart-monitor/heart-monitor.ts (2)
  • 158-158: The marketingMutation method's signature has been updated to accept fields?: Partial<GQLTwitterUser>, aligning with the updated focus on Twitter user data.
  • 341-341: The marketingMutation method's signature within the HeartMonitor class also reflects the updated data model by accepting fields?: Partial<GQLTwitterUser>.
src/gql/heart-monitor/heart-monitor.test.ts (3)
  • 101-103: The addition of imports MutationMarketingArgs, GQLMarketingMutation, and GQLTwitterUser supports the new test functionality for marketing mutations.
  • 439-466: The testMarketingMutation function correctly tests the marketing mutation functionality, ensuring the response contains expected properties and values.
  • 469-475: The test case for marketingMutation correctly invokes testMarketingMutation with appropriate arguments, ensuring the marketing mutation functionality is tested.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Lines Statements Branches Functions
Coverage: 93%
 94.62% (1197/1265) 87.7% (542/618) 88.03% (309/351)

@cgilbe27 cgilbe27 merged commit 6d9d683 into develop Feb 5, 2024
1 of 2 checks passed
@cgilbe27 cgilbe27 deleted the fix/mutation branch February 5, 2024 21:05
cgilbe27 added a commit that referenced this pull request Feb 5, 2024
@cgilbe27
Merge pull request #304 from NibiruChain/develop
8c07bab 
fix: update mutation logic (#303)
nibibot pushed a commit that referenced this pull request Feb 5, 2024
@semantic-release-bot
chore(release): 3.0.1
b7656a7 
### [3.0.1](v3.0.0...v3.0.1) (2024-02-05)

### Bug Fixes

* update mutation logic ([#303](#303)) ([6d9d683](6d9d683))

 [skip ci]
@nibibot
Copy link

nibibot commented Feb 5, 2024

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@CalicoNino CalicoNino CalicoNino approved these changes

Assignees

@cgilbe27 cgilbe27

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgilbe27 @nibibot @CalicoNino