Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _fetch_dataset #235

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

jsosulski
Copy link
Collaborator

MNE removed _fetch_dataset completely on the main branch. I simply replaced usage of _fetch_file with retrieve from pooch as done in other locations of the code.

@sylvchev
Copy link
Member

There is a flake8 error that blocks the CI, could you correct it?

@jsosulski
Copy link
Collaborator Author

I saw that as well and found it strange. On my local machine running flake8 moabb does not produce any errors and looking at the files that cause the errors, I did not even change them.

@sylvchev
Copy link
Member

sylvchev commented Oct 8, 2021

Yes, I found the error. It could be corrected easily, but I do not understand why this is raised by the CI just now. The code is in the codebase for quite some times.

@sylvchev
Copy link
Member

The linting error is now correct, we could rebase, re-run the tests and merge !

@jsosulski
Copy link
Collaborator Author

Thanks for the rebase and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants