Skip to content

Commit be45016

Browse files
m00nyONENeBioNik
m00nyONE
authored andcommitted
add hide features for misc ultimates
1 parent 892d179 commit be45016

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed

CHANGELOG.md

+10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## 2024.XX.XX - @m00nyONE
2+
- add integrity check to icon menu in the addon settings
3+
- slightly rework integrity check
4+
- add hide option for misc ultimates in combat. ( same options as for the dps list )
5+
6+
## 2024.04.23 - @m00nyONE
7+
- add @seadotarley to the addon author/credit list
8+
- icon update
9+
- reminder: I'm always open for contributions and ideas: https://github.com/m00nyONE/HodorReflexes
10+
111
## 2024.03.10 - @m00nyONE
212
- the 999k damage bug should be fixed ( at least it should happen way less frequently ) ... Sadly it's impossible to "really" fix this issue as it's about the precision of the map pings being inconsistent in the ESO API.
313
- icon update

modules/share/main.lua

+13-1
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ local function CreateSceneFragments()
450450
end
451451

452452
local function MiscUltFragmentCondition()
453-
return SV.enableMiscUltimateList and controlsVisible
453+
return M.IsMiscUltimatesListVisible() and controlsVisible
454454
end
455455

456456
local function DpsFragmentCondition()
@@ -1125,6 +1125,18 @@ function M.IsDamageListVisible()
11251125
end
11261126
end
11271127

1128+
function M.IsMiscUltimatesListVisible()
1129+
if SV.enableMiscUltimateList == 1 then
1130+
return true
1131+
elseif SV.enableMiscUltimateList == 2 then
1132+
return not IsUnitInCombat('player')
1133+
elseif SV.enableMiscUltimateList == 3 then
1134+
return not IsUnitInCombat('player') or not DoesUnitExist('boss1') and not DoesUnitExist('boss2')
1135+
else
1136+
return false
1137+
end
1138+
end
1139+
11281140
-- return the ultimate in percent from 0-100. from 100-200 its scaled acordingly. The costReduction is also taken into account
11291141
function M.GetUltPercentage(raw, abilityCost, costReduction)
11301142
local ultPercentage = 0

modules/share/menu.lua

+7-1
Original file line numberDiff line numberDiff line change
@@ -380,14 +380,20 @@ function M.BuildMenu()
380380
name = string.format("|cFFFACD%s|r", GetString(HR_MENU_MISCULTIMATES))
381381
},
382382
{
383-
type = "checkbox",
383+
type = "dropdown",
384384
name = GetString(HR_MENU_MISCULTIMATES_SHOW),
385385
tooltip = GetString(HR_MENU_MISCULTIMATES_SHOW_TT),
386386
default = M.default.enableMiscUltimateList,
387387
getFunc = function() return M.sv.enableMiscUltimateList end,
388388
setFunc = function(value)
389389
M.sv.enableMiscUltimateList = value or false
390390
end,
391+
choices = {
392+
GetString(HR_MENU_DAMAGE_SHOW_NEVER), GetString(HR_MENU_DAMAGE_SHOW_ALWAYS), GetString(HR_MENU_DAMAGE_SHOW_OUT), GetString(HR_MENU_DAMAGE_SHOW_NONBOSS),
393+
},
394+
choicesValues = {
395+
0, 1, 2, 3,
396+
},
391397
width = 'half',
392398
},
393399
{

0 commit comments

Comments
 (0)