Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark NativeScriptModule as root injector #1418

Merged
merged 1 commit into from
Jul 16, 2018
Merged

fix: mark NativeScriptModule as root injector #1418

merged 1 commit into from
Jul 16, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jul 6, 2018

fixes #1417

@sis0k0 sis0k0 added this to the 6.1 (TBD) milestone Jul 6, 2018
@sis0k0 sis0k0 self-assigned this Jul 6, 2018
@sis0k0
Copy link
Contributor Author

sis0k0 commented Jul 8, 2018

test

1 similar comment
@dtopuzov
Copy link
Contributor

test

vakrilov
vakrilov approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@vakrilov vakrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are forced to import and use private (ɵ prefixed) API for something that we should be able to do with public APIs.
Can you open an issue about it in https://github.com/angular/angular/.

@sis0k0 sis0k0 merged commit ce70add into master Jul 16, 2018
@ghost ghost removed the ready for test label Jul 16, 2018
@sis0k0 sis0k0 deleted the sis0k0/treeshakable-injectors branch July 16, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@sis0k0 sis0k0

Labels
None yet
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

Tree-shakable providers scoped to the root injector don't get registered
3 participants
@sis0k0 @dtopuzov @vakrilov