Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot attach gesture observer for more than one gesture (Android). #242

Closed
nsndeck opened this issue May 29, 2015 · 3 comments
Closed

Cannot attach gesture observer for more than one gesture (Android). #242

nsndeck opened this issue May 29, 2015 · 3 comments

Comments

@nsndeck
Copy link

nsndeck commented May 29, 2015

No description provided.

@nsndeck nsndeck self-assigned this May 29, 2015
@nsndeck nsndeck added this to the 1.1.0 milestone May 29, 2015
@nsndeck nsndeck added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed in progress labels May 29, 2015
@nsndeck
Copy link
Author

nsndeck commented May 29, 2015

fixed with commit #239

@nsndeck nsndeck closed this as completed May 29, 2015
@dtopuzov dtopuzov added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites done labels Jun 1, 2015
@nsndeck nsndeck added ready for test TSC needs to test this and confirm against live production apps and automated test suites changelog labels Jun 1, 2015
@dtopuzov dtopuzov removed the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Jun 1, 2015
@nsndeck
Copy link
Author

nsndeck commented Jun 2, 2015

Breaking change: Commits #239 and #256 introduces some breaking changes related to gestures.

  1. View.observe() method does not return a gesture observer, but stores an observer into a map collection.
    To access this map collection new version introduces a new method called View.getGestureObservers(gestureType) which returns an array of gesture observers attached to the view. Indeed this is a very rare scenario, but it supports more than one observer for a single gesture.
  2. GesturesObserver constructor now takes 3 arguments instead of only a callback. Now arguments are as follows - target (view that will listen for gestures), callback (a function that will be executed when gesture is detected) and a context (the 'this' context for the callback function).
  3. GesturesObserver observe() method now takes only a single parameter - gesture type (other parameters are now passed to the GesturesObserver constructor function).

@nsndeck nsndeck added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Jun 2, 2015
@hshristov hshristov added severity: high done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Jun 10, 2015
@lock
Copy link

lock bot commented Aug 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants