Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Blip2 T5 support request #531

Closed
yuanze1024 opened this issue Dec 2, 2023 · 5 comments
Closed

[feature request]Blip2 T5 support request #531

yuanze1024 opened this issue Dec 2, 2023 · 5 comments
Assignees
Labels
feature request New feature or request triaged Issue has been triaged by maintainers

Comments

@yuanze1024
Copy link

Hi, I fount that you have supported T5 now, but Blip2's examples only contains OPT pipeline. As for the Blip2 on T5 gets a better performance, I wonder if you can support Blip2 on FlanT5xxl? I've tried a long time, and found it's too difficult for me(who just knew TRT, and can not understand how to get ITensor's real value)...

@byshiue byshiue added the feature request New feature or request label Dec 4, 2023
@ncomly-nvidia ncomly-nvidia added the triaged Issue has been triaged by maintainers label Dec 5, 2023
@ncomly-nvidia
Copy link
Collaborator

ncomly-nvidia commented Dec 5, 2023

Thanks for the request & feedback @yuanze1024 ! We are starting to expand more into enc-dec & multi-modal models & will put this pairing on the list.

@symphonylyh symphonylyh self-assigned this Dec 5, 2023
@symphonylyh
Copy link
Collaborator

@yuanze1024 thanks! internally we have enabled BLIP2 on Flan-T5-XXL and several other LLM models. Stay tuned once we have a release for that

@yuanze1024
Copy link
Author

@yuanze1024 thanks! internally we have enabled BLIP2 on Flan-T5-XXL and several other LLM models. Stay tuned once we have a release for that

@symphonylyh Hi, is there any progress?

@symphonylyh
Copy link
Collaborator

@yuanze1024 it was a little slow moving during the US holidays. But I'm expecting the release in mid-Jan will contain this (i.e., in about 2 weeks)

@symphonylyh
Copy link
Collaborator

@yuanze1024 right on time! we now released the multi-modal support for BLIP w/ OPT or T5, and LLaVA. Please take a look :)
Annoucement: #847

Feel free to re-open this if you have encountered any issue. But since this issue is a feature request, would better file a new issue regarding any specific problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants