Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attention sink #104

Closed
jqueguiner opened this issue Oct 25, 2023 · 3 comments
Closed

Attention sink #104

jqueguiner opened this issue Oct 25, 2023 · 3 comments
Assignees
Labels
feature request New feature or request triaged Issue has been triaged by maintainers

Comments

@jqueguiner
Copy link

Hi 👋 and thanks for the amazing job can’t wait to see the developments in the next few weeks and months.

any plan to work on attention sink ?

@jdemouth-nvidia
Copy link
Collaborator

Hi @jqueguiner ,

Thanks for your support. We are considering adding that feature to TensorRT-LLM but nothing concrete at this point. We are not ready to commit on a date when it'll be added (if ever).

Thanks,
Julien

@byshiue byshiue added feature request New feature or request and removed enhancement labels Nov 7, 2023
@ncomly-nvidia ncomly-nvidia added the triaged Issue has been triaged by maintainers label Nov 9, 2023
@ncomly-nvidia
Copy link
Collaborator

ncomly-nvidia commented Jan 2, 2024

Hi @jqueguiner . StreamingLLM, a technique which takes advantage of Attention Sinks, has been added to the main branch!

Llama example. Take a look & let us know what you think!

@zhyncs
Copy link

zhyncs commented Apr 22, 2024

Hi @jqueguiner . StreamingLLM, a technique which takes advantage of Attention Sinks, has been added to the main branch!

Llama example. Take a look & let us know what you think!

Hi @ncomly-nvidia Has H2O been supported in latest main branch? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

5 participants