Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoking rubocop fails in 3.8.0-RC3 due to regexp parser error #5203

Closed
jmarrec opened this issue May 16, 2024 · 0 comments · Fixed by #5204
Closed

Invoking rubocop fails in 3.8.0-RC3 due to regexp parser error #5203

jmarrec opened this issue May 16, 2024 · 0 comments · Fixed by #5204

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented May 16, 2024

Issue overview

It worked on rc2 according to @joseph-robertson and does fail on rc3.

The path has two roots

Steps to Reproduce

$ Products/openstudio -e "require 'rubocop/rake_task'; require 'stringio'; RuboCop::RakeTask.new(:rubocop) do |t| t.options = ['--autocorrect', '--format', 'simple', '--only', 'Lint/SelfAssignment'] end; Rake.application[:rubocop].invoke"                                                          

terminate called after throwing an instance of 'std::runtime_error'                                            
  what():  Embedded file not found ':/ruby/3.2.0/gems/regexp_parser-2.9.1/lib/regexp_parser/syntax/:/ruby/3.2.0/gems/regexp_parser-2.9.1/lib/regexp_parser/syntax/versions/1.8.6.rb'
Aborted (core dumped) 

Possible Solution

ammar/regexp_parser@v2.9.0...v2.9.1
A bunch of "require" became "require_relative" and that ought to break stuff for us

probably pinning on 2.9.0 is enough

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 3.8.0-rc3

Context

@jmarrec jmarrec added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label May 16, 2024
@jmarrec jmarrec mentioned this issue May 16, 2024
19 tasks
@jmarrec jmarrec added component - Ruby bindings severity - Major Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 16, 2024
@jmarrec jmarrec self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant