Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event-based load features #166

Merged
merged 36 commits into from
Feb 5, 2025
Merged

Event-based load features #166

merged 36 commits into from
Feb 5, 2025

Conversation

mnblonsky
Copy link
Collaborator

@mnblonsky mnblonsky commented Jan 24, 2025 •
edited
Loading

Addresses #162.

  • Reference the issue your PR is fixing
  • Assign at least 1 reviewer for your PR
  • Test with run_dwelling.py or other script
  • Update documentation as appropriate
  • Update changelog as appropriate

@mnblonsky
adding ScheduledLoad example
d6cf2d3
@mnblonsky
Merge branch '153-update-examples' into 162-event-data
c2e347b
@mnblonsky
updated scheduled load example
5b83d60
@mnblonsky
moving some fields from ScheduledLoad to Equipment
bffa309
@mnblonsky
adding event based equipment from schedule
d8ef4cf
@mnblonsky
adding event based load example
a8d2afb
@mnblonsky
adding event_schedule input
175e4ad
@mnblonsky
added EventDataLoad class for equipment with event-based time series …
863c3e3 
…schedules
@mnblonsky
adding clothes dryer event schedule data
b19769e
@mnblonsky
revert default timing args for examples
4f24ba7
@mnblonsky
add option to choose equipment class when running a Dwelling
f0a5c7a
@mnblonsky
bug fix if no events exist in simulation
bf5e4d4
@mnblonsky
file clean up
d222592
@mnblonsky
bug fix for saving json files
2f1c49e
@mnblonsky
bug fix for eventDataLoad with no events
d5f4f56
@mnblonsky
bug fix if simulation ends during event
30aaede
@mnblonsky
Merge branch '153-update-examples' into 162-event-data
7f01243
@mnblonsky
event based load bug fixes
1736de9
@mnblonsky
bug fix when specifying ev event schedule
672975c
@mnblonsky
ev bug fix
423852c
@mnblonsky
removed "power" from event data in EventDataLoad
6de3bea
@mnblonsky
fixed EV external p setpoint controls
7ff21ce
@mnblonsky
fixed EventDataLoad power setpoint during outage
dde89f3
@mnblonsky
fixed bug for setting eventbasedload setpoint
95a8d44
@mnblonsky mnblonsky linked an issue Jan 24, 2025 that may be closed by this pull request
Event-based appliances and lab data #162
Open
8 tasks
@mnblonsky mnblonsky self-assigned this Jan 24, 2025
@mnblonsky mnblonsky changed the base branch from main to dev January 24, 2025 23:39
@mnblonsky mnblonsky requested a review from jmaguire1 January 27, 2025 21:29
@mnblonsky mnblonsky marked this pull request as ready for review January 28, 2025 15:27
@mnblonsky
Copy link
Collaborator Author

@jmaguire1 This is ready for review. See #162 for tasks that have been completed and others that I think we don't need to do right now (for the next release).

@jmaguire1
Copy link
Collaborator

@mnblonsky: Saw that, I'll review it today! I agree it's not a must have for next release, but it would be nice to have some of these capabilities in there and we're pretty close. We should definitely chat about what we want to get into the new release later today or at our next dev meeting so we can get that done before you go away for a bit.

jmaguire1
jmaguire1 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few local runs to make sure this all works, and looking through the code no major comments or questions. Good job!

We should maybe talk about a couple minor things in our dev meeting later, but I have no issue with merging this in.

@jmaguire1 jmaguire1 merged commit 4e1a99d into dev Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaguire1 jmaguire1 jmaguire1 approved these changes

Assignees

@mnblonsky mnblonsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event-based appliances and lab data
2 participants
@mnblonsky @jmaguire1