Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13pt] Remove Grass from solution #756

Closed
RobHanna-NOAA opened this issue Dec 8, 2022 · 1 comment · Fixed by #814
Closed

[13pt] Remove Grass from solution #756

RobHanna-NOAA opened this issue Dec 8, 2022 · 1 comment · Fixed by #814
Assignees
Labels
bug Something isn't working enhancement New feature or request FIM4 Med Priority

Comments

@RobHanna-NOAA
Copy link
Contributor

Found in r_grow_distance.py and possibly some other places.

Recommended by Yan to be removed for performance reasons. It created perm issues in Windows and EC2's (but both got around it).

Possible alternatives: Whitebox (Jim found) or Numpy (Matt might have something on this).

Grass would need to be removed from the Dockerfile and whatever its replacement is will likely be added to the Pipfile. Could be needed in Dockerfile but Pipfile is best if possible)

@RobHanna-NOAA RobHanna-NOAA added bug Something isn't working enhancement New feature or request Med Priority FIM4 labels Dec 8, 2022
@RobHanna-NOAA RobHanna-NOAA changed the title [8pt] Remove Grass from solution [13pt] Remove Grass from solution Dec 8, 2022
@mluck
Copy link
Contributor

mluck commented Feb 15, 2023

Continuing from #702:
A comparison of GRASS vs. Whitebox resulted in nearly identical outputs. I confirmed that the projection issue seems to be a result of the inexact cell size value in the GRASS processes. For example, the agree_bufgrid_allo.tif from GRASS has a different origin than that of the original DEM data whereas Whitebox is the same as the DEM:

HUC8: 3100204 Origin(GRASS) Origin(Whitebox)
dem_meters.tif 1335009.4094358840957284,610714.2824222166091204 1335009.4094358840957284,610714.2824222166091204
agree_bufgrid_allo.tif 1335009.4094358799047768,610714.2824222199851647 1335009.4094358840957284,610714.2824222166091204

As a result, there are slight differences in the REM rasters which originated from the stream lines being occasionally different using the two engines. In most cases this produces a random pixel shift here and there, but in a few cases the effect is more severe. In particular, the effect of slightly different stream lines accentuates other issues within the underlying datasets, most notably when it is located in conjunction with a thalweg notch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request FIM4 Med Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants