Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13pt] NWM lake polygon masking for upstream branch catchments #755

Closed
RyanSpies-NOAA opened this issue Dec 5, 2022 · 3 comments · Fixed by #802
Closed

[13pt] NWM lake polygon masking for upstream branch catchments #755

RyanSpies-NOAA opened this issue Dec 5, 2022 · 3 comments · Fixed by #802
Assignees
@RyanSpies-NOAA
Labels
enhancement New feature or request FIM4
Milestone
FIM v4.0

Comments

@RyanSpies-NOAA
Copy link
Collaborator

RyanSpies-NOAA commented Dec 5, 2022 •
edited
Loading

Current GMS solution allows for some upstream branch catchments to inundate some NWM lake areas using flowline from downstream of the water body. Need to identify solution to prevent unwanted inundation within the NWM lake polygons.

Example of a NWM waterbody showing inundation (FIM 4.0.9.2) in huc 11140305 -->
image
@RyanSpies-NOAA RyanSpies-NOAA self-assigned this Dec 5, 2022
@RyanSpies-NOAA RyanSpies-NOAA added FIM4 enhancement New feature or request labels Dec 5, 2022
@RyanSpies-NOAA RyanSpies-NOAA added this to the FIM v4.0 milestone Dec 5, 2022
@RyanSpies-NOAA
Copy link
Collaborator Author

More examples:
HUC 12060202 -->
image

HUC 12030109 -->
image

@RyanSpies-NOAA
Copy link
Collaborator Author

HUC 12030109 (NWM lake id: 1445978) is inundated due to branch 02. The headwater catchment for the branch (hydroid 24450001) begins with a NWM streamline (order=3) at the lake outlet. There is a NWM streamline (order=3) upstream of this one inside the lake polygon (red flowline in image below). It is currently filtered when generating the nwm_subset_streams_levelPaths_dissolved.gpkg file (removes lakeid flowlines).
image

@RyanSpies-NOAA
Copy link
Collaborator Author

This issue is an extension of #663

@RyanSpies-NOAA RyanSpies-NOAA linked a pull request Jan 25, 2023 that will close this issue
[1pt] PR: branch trimming for lake segments #802
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanSpies-NOAA RyanSpies-NOAA

Labels
enhancement New feature or request FIM4
Projects
None yet
Milestone
FIM v4.0
Development

Successfully merging a pull request may close this issue.

[1pt] PR: branch trimming for lake segments NOAA-OWP/inundation-mapping
1 participant
@RyanSpies-NOAA