Skip to content

Commit fca8282

Browse files
climbfujigrantfirl
andauthored
Wrapper PR for "Update CCPP standard names for consistency (#337)" (#356)
* update standard names in accordance with CCPPStandardNames PR#13 as of 2021/7/1 * Fix merge conflicts in ccpp/data/GFS_typedefs.meta Co-authored-by: grantfirl <grantf@ucar.edu>
1 parent f8732ff commit fca8282

File tree

5 files changed

+1358
-1355
lines changed

5 files changed

+1358
-1355
lines changed

ccpp/config/ccpp_prebuild_config.py

+18-18
Original file line numberDiff line numberDiff line change
@@ -272,27 +272,27 @@
272272
},
273273
'mp_thompson' : {
274274
'mp_thompson_init' : [
275-
'cloud_droplet_number_concentration',
276-
'water_friendly_aerosol_number_concentration',
277-
'ice_friendly_aerosol_number_concentration',
278-
'tendency_of_water_friendly_aerosols_at_surface',
279-
'tendency_of_ice_friendly_aerosols_at_surface',
275+
'mass_number_concentration_of_cloud_liquid_water_particles_in_air',
276+
'mass_number_concentration_of_hygroscopic_aerosols',
277+
'mass_number_concentration_of_nonhygroscopic_ice_nucleating_aerosols',
278+
'tendency_of_hygroscopic_aerosols_at_surface_adjacent_layer',
279+
'tendency_of_nonhygroscopic_ice_nucleating_aerosols_at_surface_adjacent_layer',
280280
# DH* 2020-06-01: turn off calculation of effective radii, now done in GFS_rrtmg_pre
281-
#'effective_radius_of_stratiform_cloud_liquid_water_particle_in_um',
282-
#'effective_radius_of_stratiform_cloud_ice_particle_in_um',
283-
#'effective_radius_of_stratiform_cloud_snow_particle_in_um',
281+
#'effective_radius_of_stratiform_cloud_liquid_water_particle',
282+
#'effective_radius_of_stratiform_cloud_ice_particle',
283+
#'effective_radius_of_stratiform_cloud_snow_particle',
284284
# *DH 2020-06-01
285285
],
286286
'mp_thompson_run' : [
287-
'cloud_droplet_number_concentration_updated_by_physics',
288-
'water_friendly_aerosol_number_concentration_updated_by_physics',
289-
'ice_friendly_aerosol_number_concentration_updated_by_physics',
290-
'tendency_of_water_friendly_aerosols_at_surface',
291-
'tendency_of_ice_friendly_aerosols_at_surface',
287+
'mass_number_concentration_of_cloud_liquid_water_particles_in_air_of_new_state',
288+
'mass_number_concentration_of_hygroscopic_aerosols_of_new_state',
289+
'mass_number_concentration_of_nonhygroscopic_ice_nucleating_aerosols_of_new_state',
290+
'tendency_of_hygroscopic_aerosols_at_surface_adjacent_layer',
291+
'tendency_of_nonhygroscopic_ice_nucleating_aerosols_at_surface_adjacent_layer',
292292
# DH* 2020-06-01: turn off calculation of effective radii, now done in GFS_rrtmg_pre
293-
#'effective_radius_of_stratiform_cloud_liquid_water_particle_in_um',
294-
#'effective_radius_of_stratiform_cloud_ice_particle_in_um',
295-
#'effective_radius_of_stratiform_cloud_snow_particle_in_um',
293+
#'effective_radius_of_stratiform_cloud_liquid_water_particle',
294+
#'effective_radius_of_stratiform_cloud_ice_particle',
295+
#'effective_radius_of_stratiform_cloud_snow_particle',
296296
# *DH 2020-06-01
297297
],
298298
},
@@ -303,13 +303,13 @@
303303
},
304304
'GFS_rrtmgp_sw_post' : {
305305
'GFS_rrtmgp_sw_post_run' : [
306-
'tendency_of_air_temperature_due_to_shortwave_heating_assuming_clear_sky_on_radiation_time_step',
306+
'tendency_of_air_temperature_due_to_shortwave_heating_assuming_clear_sky_on_radiation_timestep',
307307
'components_of_surface_downward_shortwave_fluxes',
308308
],
309309
},
310310
'GFS_rrtmgp_lw_post' : {
311311
'GFS_rrtmgp_lw_post_run' : [
312-
'tendency_of_air_temperature_due_to_longwave_heating_assuming_clear_sky_on_radiation_time_step',
312+
'tendency_of_air_temperature_due_to_longwave_heating_assuming_clear_sky_on_radiation_timestep',
313313
],
314314
},
315315
#'subroutine_name_1' : 'all',

ccpp/data/CCPP_data.meta

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,5 @@
4646
standard_name = GFS_interstitial_type_instance_all_threads
4747
long_name = instance of derived type GFS_interstitial_type
4848
units = DDT
49-
dimensions = (omp_threads)
49+
dimensions = (number_of_openmp_threads)
5050
type = GFS_interstitial_type

ccpp/data/GFS_typedefs.F90

+4-3
Original file line numberDiff line numberDiff line change
@@ -1970,6 +1970,7 @@ module GFS_typedefs
19701970
integer :: nsamftrac !<
19711971
integer :: nscav !<
19721972
integer :: nspc1 !<
1973+
integer :: ntcwx !<
19731974
integer :: ntiwx !<
19741975
integer :: ntk !<
19751976
integer :: ntkev !<
@@ -6904,7 +6905,7 @@ subroutine interstitial_create (Interstitial, IM, Model)
69046905
!
69056906
allocate (Interstitial%otspt (Model%ntracp1,2))
69066907
! Set up numbers of tracers for PBL, convection, etc: sets
6907-
! Interstitial%{nvdiff,mg3_as_mg2,nn,tracers_total,ntiwx,ntk,ntkev,otspt,nsamftrac,ncstrac,nscav}
6908+
! Interstitial%{nvdiff,mg3_as_mg2,nn,tracers_total,ntcwx,ntiwx,ntk,ntkev,otspt,nsamftrac,ncstrac,nscav}
69086909
call interstitial_setup_tracers(Interstitial, Model)
69096910
! Allocate arrays
69106911
allocate (Interstitial%adjsfculw_land (IM))
@@ -7443,8 +7444,7 @@ subroutine interstitial_setup_tracers(Interstitial, Model)
74437444

74447445
Interstitial%nscav = Model%ntrac - Model%ncnd + 2
74457446

7446-
7447-
! DH* STILL VALID GIVEN THE CHANGES BELOW FOR CPLCHM?
7447+
Interstitial%ntcwx = Model%ntcw
74487448
if (Interstitial%nvdiff == Model%ntrac) then
74497449
Interstitial%ntiwx = Model%ntiw
74507450
else
@@ -8012,6 +8012,7 @@ subroutine interstitial_print(Interstitial, Model, mpirank, omprank, blkno)
80128012
write (0,*) 'Interstitial%nsamftrac = ', Interstitial%nsamftrac
80138013
write (0,*) 'Interstitial%nscav = ', Interstitial%nscav
80148014
write (0,*) 'Interstitial%nspc1 = ', Interstitial%nspc1
8015+
write (0,*) 'Interstitial%ntcwx = ', Interstitial%ntcwx
80158016
write (0,*) 'Interstitial%ntiwx = ', Interstitial%ntiwx
80168017
write (0,*) 'Interstitial%nvdiff = ', Interstitial%nvdiff
80178018
write (0,*) 'Interstitial%phys_hydrostatic = ', Interstitial%phys_hydrostatic

0 commit comments

Comments
 (0)