Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive "Load the cloud coefficients" print out in gsi.x built with crtm/2.4.0 #556

Closed
RussTreadon-NOAA opened this issue Mar 28, 2023 · 4 comments

Comments

@RussTreadon-NOAA
Copy link
Contributor

@jderber-NOAA noticed that when we run gsi.x on Hera with crtm/2.4.0 we find

Load the cloud coefficients:
...Cloud model: CRTM
...CloudCoeff file: ./crtm_coeffs/CloudCoeff.bin

written to stdout hundreds to times. This is also true on Orion. This printout is not in the operational global crtm/2.4.0 gsi.x job log files.

A check of Orion /apps/contrib/NCEP/hpc-stack/src/hpc-stack/pkg/crtm-v2.4.0/libsrc/CRTM_LifeCycle.f90 finds

    ! Load the cloud coefficients
    IF ( Local_Load_CloudCoeff ) THEN
      WRITE(*, '("Load the cloud coefficients: ") ')
      WRITE(*, '("...Cloud model: ", a) ') TRIM(Default_Cloud_Model)
      WRITE(*, '("...CloudCoeff file: ", a) ') TRIM(Default_CloudCoeff_File)
      err_stat = CRTM_CloudCoeff_Load( &

Hera /scratch2/NCEPDEV/nwprod/hpc-stack/src/v1.2.0/pkg/crtm/libsrc/CRTM_LifeCycle.f90 contains

    ! Load the cloud coefficients
    IF ( Local_Load_CloudCoeff ) THEN
!!$      WRITE(*, '("Load the cloud coefficients: ") ')
!!$      WRITE(*, '("...Cloud model: ", a) ') TRIM(Default_Cloud_Model)
!!$      WRITE(*, '("...CloudCoeff file: ", a) ') TRIM(Default_CloudCoeff_File)
      err_stat = CRTM_CloudCoeff_Load( &

The above Hera copy of CRTM_LifeCycle.f90 is dated Dec 18 2021. The crtm/2.4.0 include files and library are dated Jun 14 2022. It seems the Hera crtm/2.4.0, like Orion, was built with the load cloudcoeff writes active.

We should turn off this printout in crtm/2.4.0 on Orion and Hera.

Are the crtm/2.4.0 versions installed on Hera, Orion, and WCOSS2 identical?

@RussTreadon-NOAA
Copy link
Contributor Author

Tagging @emilyhcliu , @ADCollard , and @HaixiaLiu-NOAA .

@emilyhcliu
Copy link
Contributor

emilyhcliu commented Mar 28, 2023

The repeated messages are indeed coming from CRTM 2.4.0 EMC installation.
I did not find this in JEDI crtm2.4..0 build.
I think the crtm/2.4.0 on Orion and Hera are identical.
We asked them to pull the crtm/2.4.0 from the JCSDA official site to build.

@DavidHuber-NOAA
Copy link
Collaborator

I would like to mimic this build on S4. Is there a particular repository or branch of the CRTM that has these print statements removed?

@emilyhcliu
Copy link
Contributor

I would like to mimic this build on S4. Is there a particular repository or branch of the CRTM that has these print statements removed?

The CRTM-2.4.0_emc from JCSDA CRTM official GitHub repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants