Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzAllowEmpty icon can be clicked when TimePicker has been disabled #5980

Closed
rencoo opened this issue Oct 27, 2020 · 4 comments
Closed

nzAllowEmpty icon can be clicked when TimePicker has been disabled #5980

rencoo opened this issue Oct 27, 2020 · 4 comments

Comments

@rencoo
Copy link
Contributor

rencoo commented Oct 27, 2020

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-ivy-hgux55

Steps to reproduce

  • select time when TimePicker is active
  • disable TimePicker and watch if nzAllowEmpty icon can be clicked

What is expected?

nzAllowEmpty icon can not be clicked when TimePicker has been disabled

What is actually happening?

nzAllowEmpty icon can be clicked when TimePicker has been disabled

Environment Info
ng-zorro-antd 10.0.2
Browser chrome
@zorro-bot
Copy link

zorro-bot bot commented Oct 29, 2020

Hello @rencoo. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @rencoo, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@wenqi73
Copy link
Member

wenqi73 commented Oct 29, 2020

Should not display the clear icon when disabled.

@stygian-desolator
Copy link
Collaborator

Hello. I would like to fix this issue, if no one is already on it.

@wenqi73
Copy link
Member

wenqi73 commented Oct 30, 2020

closed via #5990

@wenqi73 wenqi73 closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants