Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topo Editor depth/mask/basinmask buttons don't work as expected. #7

Open
AidanJanney opened this issue Mar 13, 2025 · 1 comment
Open

Comments

@AidanJanney
Copy link

When using the Topo Editor, the depth, mask, and basinmask buttons have some weird and unreliable behavior. The Topo Editor plots the original bathymetry depth accurately, and the selection of the mask and basinmask options correctly switches to those views.

  • After swapping to the mask or basinmask view, selecting the depth button again does not work. It instead switches to a plot with a color bar that almost acts as another land/ocean mask (see image below). I can't find a way to return to the original depth view after selecting another view. The same thing happens when selecting a cell by double clicking, it switches the depth view to the following plot that acts like a land/ocean mask.

Image

  • After erasing a basin and changing the total depth scale, the plot would sometimes show cells with depth less than the minimum depth as having depth. This is only shown on the depth display, the mask and basin mask still correctly show the shallow regions as land. See the image below, and the region next to the southern coast of Panama after the Pacific basin has been removed. I think this happens because the erase basin does not target cells that are under the minimum depth, so they still have their original depth after erasing a basin. This is actually what the issues in my original PR were referencing: Added "Remove Selected Basin" button to the Topo Editor #3 (comment).

Image

  • Cannot edit the minimum depth using the input box without receiving an error.

I think Manish has already addressed most of these issues in his PR: #5 (comment).

@AidanJanney AidanJanney changed the title Topo Editor depth/mask/basinmask buttons don't work with minimum depth or minimum depth. Topo Editor depth/mask/basinmask buttons don't work as expected. Mar 13, 2025
@manishvenu
Copy link
Collaborator

Yup, everything except the last bullet point I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants