Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brent's method for minimization #15

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Conversation

nossleinad
Copy link
Collaborator

@nossleinad nossleinad commented Feb 29, 2024

This pull request implements Brent's method for minimization and calls it brents_method_minimize. It also makes it an option as an optimizer for branchlength_optim!. This method can be used for 1D unimodal optimization problems and it doesn't use derivatives.

Additionally, this pull request generalizes golden_section_maximize and brents_method_minimize with univariate_maximize. It dispatches on the two different subtypes, GoldenSectionOptand BrentsMethodOpt, of the new UnivariateOpt-type.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.99%. Comparing base (6930e8d) to head (3abdcf3).

Files Patch % Lines
src/core/algorithms/branchlength_optim.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   31.23%   32.99%   +1.76%     
==========================================
  Files          30       30              
  Lines        2126     2182      +56     
==========================================
+ Hits          664      720      +56     
  Misses       1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murrellb murrellb merged commit 53f75c0 into MurrellGroup:main Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants