Add Brent's method for minimization #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements Brent's method for minimization and calls it
brents_method_minimize
. It also makes it an option as an optimizer forbranchlength_optim!
. This method can be used for 1D unimodal optimization problems and it doesn't use derivatives.Additionally, this pull request generalizes
golden_section_maximize
andbrents_method_minimize
withunivariate_maximize
. It dispatches on the two different subtypes,GoldenSectionOpt
andBrentsMethodOpt
, of the newUnivariateOpt
-type.