Skip to content

Set fetch timeout to 5 seconds #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Set fetch timeout to 5 seconds #45

merged 1 commit into from
Apr 9, 2025

Conversation

MinSeungHyun
Copy link
Owner

Fixes #42
인터넷 상태가 불안정한 상황에서 fetch request가 비정상적으로 오래 걸릴 수 있다는 것이 문제라는 가설
크롬의 기본 timeout은 30초이기 때문에 5초로 줄임

@MinSeungHyun MinSeungHyun added the bug Something isn't working label Apr 9, 2025
@MinSeungHyun MinSeungHyun requested a review from Copilot April 9, 2025 05:36
@MinSeungHyun MinSeungHyun self-assigned this Apr 9, 2025
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/core/login/update-learnus-sesskey.ts:6

  • [nitpick] Consider extracting the timeout value (5000) into a named constant for easier configuration and maintenance.
signal: AbortSignal.timeout(5000),

src/core/login/login-portal.ts:22

  • [nitpick] Consider extracting the magic number 5000 into a constant to enhance code consistency and ease future adjustments.
signal: AbortSignal.timeout(5000),

src/core/login/login-learnus.ts:29

  • [nitpick] Consider extracting the timeout duration (5000) into a well-named constant to avoid repeated magic numbers and simplify updates.
signal: AbortSignal.timeout(5000),

@MinSeungHyun MinSeungHyun merged commit eb70601 into main Apr 9, 2025
4 checks passed
@MinSeungHyun MinSeungHyun deleted the bug/42 branch April 9, 2025 05:37
@MinSeungHyun MinSeungHyun mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@MinSeungHyun MinSeungHyun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'로그인 중' overlay가 사라지지 않는 문제
1 participant
@MinSeungHyun