Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-349: Don't report -1 as failure line number at runtime mode #349

Closed
ZodmanPerth opened this issue Dec 24, 2022 · 2 comments · Fixed by #354
Closed

GD-349: Don't report -1 as failure line number at runtime mode #349

ZodmanPerth opened this issue Dec 24, 2022 · 2 comments · Fixed by #354
Assignees
Labels
documentation Improvements or additions to documentation task A taks is a issue to define a task to needs be done
Milestone

Comments

@ZodmanPerth
Copy link

The used Godot version:
v3.5.1.stable.official [6fed1ffa3]

OS including version:
Windows 11

Describe the bug
The line number on the report shows the correct line when debugging tests, but when running tests without the debugger the line number is reported as -1

Debug Time:
image

Run Time:
image

Steps to Reproduce

  1. Create a test with the reproduction method provided below
  2. Run the test with debug
  3. Observe the correct line number is reported
  4. Run the test without debug
  5. Observe the line number is reported as -1

Minimal reproduction project:

func test_lineNumber():
	assert_bool(false).is_true()
@ZodmanPerth ZodmanPerth added the bug Something isn't working label Dec 24, 2022
@MikeSchulze
Copy link
Owner

This is not a bug, Godot do not give a full stacktrace at runtime mode.
This info is only available at debug mode.

I have to add this info to the documentation, to not confuse the user.

@MikeSchulze MikeSchulze added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 25, 2022
@MikeSchulze MikeSchulze added this to the v2.3.2 milestone Dec 25, 2022
@ZodmanPerth
Copy link
Author

In that case I suggest you remove the line number part of the report at runtime and only show it at debug time.

@MikeSchulze MikeSchulze added the task A taks is a issue to define a task to needs be done label Dec 27, 2022
@MikeSchulze MikeSchulze changed the title Line number in report is -1 when running without debugger GD-349: Line number in report is -1 when running without debugger Dec 27, 2022
@github-project-automation github-project-automation bot moved this to Done in GdUnit3 Dec 28, 2022
@MikeSchulze MikeSchulze changed the title GD-349: Line number in report is -1 when running without debugger GD-349: Don't report -1 as failure line number at runtime mode Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation task A taks is a issue to define a task to needs be done
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants