Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback:"Close" button is not accessible through keyboard when NVDA is ON. #51900

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 6 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities info-needed Issue requires more information from poster macos Issues with VS Code on MAC/OS X
Milestone

Comments

@AccessibilityTestingTeam-TCS
Copy link

AccessibilityTestingTeam-TCS commented Jun 14, 2018

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
Keyboard,NVDA[2018.2],JAWS[18.0.5038],Voiceover[MACOS High Sierra 10.13.5 Beta (17F70a)
]
Repro Steps:

  1. Launch VS Code.
    2.Navigate to Status Bar and select "Tweet Feedback" button.
  2. Check the keyboard navigation.

Actual:
"Close" button is not accessible through keyboard when NVDA is ON.
Same issue observed in MAC also.
Expected:

"Close" button should accessible through keyboard.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
The keyboard user will not be able to access the control.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}

Does this issue occur when all extensions are disabled?: Yes
Attachment for Reference:
[Accessibility]A11y_VSCode_Feedback_Keyboard2.pptx

@RMacfarlane RMacfarlane added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 15, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-feedback workbench-status Status bar help wanted Issues identified as good community contribution opportunities labels Jun 15, 2018
@joaomoreno joaomoreno modified the milestones: May 2018 Recovery, Backlog Jun 15, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_Feedback_Keyboard:"Close" button is not accessible through keyboard when NVDA is ON. Feedback:"Close" button is not accessible through keyboard when NVDA is ON. Jul 5, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 5, 2018

You can close the feedback widget using ESC.
@AccessibilityTestingTeam-TCS Why is that not enough?

@isidorn isidorn added the info-needed Issue requires more information from poster label Jul 5, 2018
@bpasero bpasero removed the workbench-status Status bar label Jul 5, 2018
@AccessibilityTestingTeam-TCS
Copy link
Author

It is working by using ESc key but pressed after twice.Please refer the attachment

@AccessibilityTestingTeam-TCS
Copy link
Author

@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2018

No. Pressing Esc once works perfectly fine both on Win and Mac for me.

@AccessibilityTestingTeam-TCS
Copy link
Author

It is working fine on below environment,hence close this bug
Version: 1.27.0-insider
Commit: 0779618
Date: 2018-08-21T08:48:57.835Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the macos Issues with VS Code on MAC/OS X label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities info-needed Issue requires more information from poster macos Issues with VS Code on MAC/OS X
Projects
None yet
Development

No branches or pull requests

6 participants