Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to dx.doi.org doesn't finish #35

Closed
c-langlet opened this issue Jul 29, 2024 · 4 comments
Closed

Request to dx.doi.org doesn't finish #35

c-langlet opened this issue Jul 29, 2024 · 4 comments

Comments

@c-langlet
Copy link

There seems to be a bug when querying the dx.doi.org server to ensure DOI existence throught the requests API.

I managed to solve the bug by changing url definition in pdf2doi.finders.validate_doi_web from (line 48):
url = "http://dx.doi.org/" + doi
to
url = "https://dx.doi.org/" + doi

My configuration:

python 3.10
pdf2doi 1.6
requests 2.25.1

Thanks for the useful module !

@MicheleCotrufo
Copy link
Owner

Thanks for letting us know. It might be some change on the doi.org website. Which error message do you get?

@c-langlet
Copy link
Author

I don't get any, the request never ends

@MicheleCotrufo
Copy link
Owner

Thanks, I'll change the url as you suggested in the next version

@MicheleCotrufo
Copy link
Owner

I implemented this change in version 1.7 (just published), please re-open the issue if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants