Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep up with the latest version of MochaJS (and specially for the issue mochajs/mocha#2095 which often ruined the report of my client-tests) I decided to take a look at how we could integrate its latest version.
As https://github.com/practicalmeteor/meteor-mocha-core seems to be abandoned (open PRs are left without any further notification for a long time), I've created a fork on this user (https://github.com/meteortesting/meteor-mocha-core). I first updated to MochaJS in version 3.5.3 and raised the version number to
1.0.1
- MochaJS 4.x.x doesn't seem to support PhantomJS anymore - at least my tests failed (see: Meteor-Community-Packages/meteor-mocha-core#1).Since the tests only failed in PhantomJS, and the owner of the project
decided tohas archive it (ariya/phantomjs#15344), I decided to move on and see how far I can get.I went straight to version
5.2.0
, which is the latest as of the time writing, and committed it as a proposal for a1.0.2
which works great usingpuppeteer
as browser, which is as easy to add as PhantomJS.Some ideas (some unresolved) still in my head where I want your opinion on:
1.0.0
,1.0.1
and1.0.2
on atmosphere, so people could fix their project to e.g.1.0.1
by locally requiring the package if they still need to support PhantomJS.MaybeWe should follow Selenium and deprecate PhantomJS by including a warning (see: SeleniumHQ/selenium@b3daa03),or should we rather go for fixing Update to mocha 4.x meteor-mocha-core#1?